From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O4VIu-0000JV-Mu for qemu-devel@nongnu.org; Wed, 21 Apr 2010 04:29:04 -0400 Received: from [140.186.70.92] (port=45617 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O4VIr-0000I4-T0 for qemu-devel@nongnu.org; Wed, 21 Apr 2010 04:29:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O4VIq-0007cw-2Z for qemu-devel@nongnu.org; Wed, 21 Apr 2010 04:29:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25250) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4VIp-0007cY-Qd for qemu-devel@nongnu.org; Wed, 21 Apr 2010 04:29:00 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3L8SvGu027018 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 21 Apr 2010 04:28:57 -0400 Date: Wed, 21 Apr 2010 09:28:55 +0100 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string() Message-ID: <20100421082855.GB12843@redhat.com> References: <1271797792-24571-1-git-send-email-lcapitulino@redhat.com> <1271797792-24571-8-git-send-email-lcapitulino@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1271797792-24571-8-git-send-email-lcapitulino@redhat.com> Reply-To: "Daniel P. Berrange" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On Tue, Apr 20, 2010 at 06:09:37PM -0300, Luiz Capitulino wrote: > There are error handling functions in QEMU which print errno codes > to the user. While it's debatable if this is good from a user > perspective, sometimes it's the best you can do because it's what > system calls return and this is also useful for debugging. > > So, we need a way to expose those codes in QMP. We can't use the > codes themselfs because they may vary between systems. > > The best solution I can think of is returning the string > representation of the name. For example, EIO becomes "EIO". > > This is what get_errno_string() does. > > Signed-off-by: Luiz Capitulino > --- > qemu-error.c | 25 +++++++++++++++++++++++++ > qemu-error.h | 1 + > 2 files changed, 26 insertions(+), 0 deletions(-) > > diff --git a/qemu-error.c b/qemu-error.c > index 5a35e7c..55ce133 100644 > --- a/qemu-error.c > +++ b/qemu-error.c > @@ -207,3 +207,28 @@ void error_report(const char *fmt, ...) > va_end(ap); > error_printf("\n"); > } > + > +/* > + * This is probably only useful for QMP > + */ > +const char *get_errno_string(int err) > +{ > + assert(err < 0); > + > + switch (err) { > + case -EINVAL: > + return "EINVAL"; > + case -EIO: > + return "EIO"; > + case -ENOENT: > + return "ENOENT"; > + case -ENOMEDIUM: > + return "ENOMEDIUM"; > + case -ENOTSUP: > + return "ENOTSUP"; > + default: > + return "unknown"; > + } > + > + abort(); > +} Wouldn't it be nicer to return strerror_r() output instead of errno names ? Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|