From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O4wXD-0003ov-Ue
	for qemu-devel@nongnu.org; Thu, 22 Apr 2010 09:33:39 -0400
Received: from [140.186.70.92] (port=50913 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O4wXC-0003oB-8t
	for qemu-devel@nongnu.org; Thu, 22 Apr 2010 09:33:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1O4wX9-0004rG-Je
	for qemu-devel@nongnu.org; Thu, 22 Apr 2010 09:33:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:22544)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1O4wX9-0004r2-C9
	for qemu-devel@nongnu.org; Thu, 22 Apr 2010 09:33:35 -0400
Received: from int-mx08.intmail.prod.int.phx2.redhat.com
	(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3MDXX6N004460
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 22 Apr 2010 09:33:33 -0400
Date: Thu, 22 Apr 2010 10:33:22 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20100422103322.475e096b@redhat.com>
In-Reply-To: <4BCF1CFE.50001@redhat.com>
References: <1271797792-24571-1-git-send-email-lcapitulino@redhat.com>
	<1271797792-24571-5-git-send-email-lcapitulino@redhat.com>
	<m3mxwx3jbc.fsf@trasno.mitica> <20100420185959.31829121@redhat.com>
	<m3y6gh19te.fsf@trasno.mitica> <20100421115410.5226f1dc@redhat.com>
	<m3mxwwolwr.fsf@trasno.mitica> <4BCF1CFE.50001@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume
	the VM
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: armbru@redhat.com, qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>

On Wed, 21 Apr 2010 17:42:54 +0200
Kevin Wolf <kwolf@redhat.com> wrote:

> Am 21.04.2010 17:39, schrieb Juan Quintela:
> > Luiz Capitulino <lcapitulino@redhat.com> wrote:
> >> 2. Don't keep the VM paused when recovery is possible
> >>
> >>  If you can fix that, it's ok to me: I'll drop this and the next patch.
> >>
> >>  Otherwise I'll have to insist on the split.
> > 
> > Re-read my email.   At this point, nothing is fixable :(  After doing
> > the 1st:
> > 
> >>>             ret = bdrv_snapshot_goto(bs1, name);
> > 
> > and not returning an error -> state has changed, period.  You can't
> > restart the machine.
> 
> Right, at this point. But the most likely error for bdrv_snapshot_goto
> is that the snapshot doesn't even exist. This is something that you can
> check before you change any state. I think this is what Luiz meant (at
> least it is what I said and he agreed).

 Yes, that's it.