From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O4uBK-0002pv-Uz for qemu-devel@nongnu.org; Thu, 22 Apr 2010 07:02:55 -0400 Received: from [140.186.70.92] (port=53138 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O4uBJ-0002pS-7D for qemu-devel@nongnu.org; Thu, 22 Apr 2010 07:02:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O4uBH-0005MG-As for qemu-devel@nongnu.org; Thu, 22 Apr 2010 07:02:52 -0400 Received: from verein.lst.de ([213.95.11.210]:55950) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4uBH-0005JO-2X for qemu-devel@nongnu.org; Thu, 22 Apr 2010 07:02:51 -0400 Date: Thu, 22 Apr 2010 13:02:43 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH v2] qcow2: Fix creation of large images Message-ID: <20100422110243.GA1949@lst.de> References: <1271683281-26825-1-git-send-email-kwolf@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1271683281-26825-1-git-send-email-kwolf@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, quintela@redhat.com On Mon, Apr 19, 2010 at 03:21:21PM +0200, Kevin Wolf wrote: > qcow_create2 assumes that the new image will only need one cluster for its > refcount table initially. Obviously that's not true any more when the image is > big enough (exact value depends on the cluster size). > > This patch calculates the refcount table size dynamically. > > Signed-off-by: Kevin Wolf Looks good, Reviewed-by: Christoph Hellwig