From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O4x4m-0007Vg-ET
	for qemu-devel@nongnu.org; Thu, 22 Apr 2010 10:08:20 -0400
Received: from [140.186.70.92] (port=60831 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O4x4k-0007UR-Sg
	for qemu-devel@nongnu.org; Thu, 22 Apr 2010 10:08:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kauer@os.inf.tu-dresden.de>) id 1O4x4g-0002lQ-Fv
	for qemu-devel@nongnu.org; Thu, 22 Apr 2010 10:08:18 -0400
Received: from os.inf.tu-dresden.de ([141.76.48.99]:34724)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kauer@os.inf.tu-dresden.de>) id 1O4x4g-0002l2-Al
	for qemu-devel@nongnu.org; Thu, 22 Apr 2010 10:08:14 -0400
Date: Thu, 22 Apr 2010 16:08:11 +0200
From: Bernhard Kauer <kauer@os.inf.tu-dresden.de>
Subject: Re: [Qemu-devel] [PATCH] fix curses update
Message-ID: <20100422140811.GA27272@chrom.inf.tu-dresden.de>
References: <20100420093835.GC9079@chrom.inf.tu-dresden.de>
	<x2ifb249edb1004211827m626658d1p97a275e76b1a7104@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <x2ifb249edb1004211827m626658d1p97a275e76b1a7104@mail.gmail.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: andrzej zaborowski <balrogg@gmail.com>
Cc: qemu-devel@nongnu.org

Hi,

> I believe this issue has come up before with a similar patch but

well i've submitted such a patch more than two years ago.  Unfortunatelly
it got never applied, so that I have to patch my Qemu on every update...


> someone checked their ncurses and they didn't see the same issue. 
> I just checked and here mvwaddchnstr() does not expect a null-terminated
> string either, but it skips the \0 characters.

This is not conforming to the Single UNIX Specification, which states
that the string is shown "until a null chtype is encountered". See for
example:
  http://www.opengroup.org/onlinepubs/007908775/xcurses/addchstr.html 


>  So probably we should
> replace them with spaces or something else,  I wouldn't like to
> replace a single library call with 80 calls, it's better to go through
> the string and replace them, maybe in console_write_ch or somewhere
> else.

That would be a one-liner.  Should I send such a patch?


Thanks,

	Bernhard