From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O5LbH-0004i5-VA for qemu-devel@nongnu.org; Fri, 23 Apr 2010 12:19:31 -0400 Received: from [140.186.70.92] (port=32994 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O5LbG-0004hP-IX for qemu-devel@nongnu.org; Fri, 23 Apr 2010 12:19:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O5LbF-00052U-7M for qemu-devel@nongnu.org; Fri, 23 Apr 2010 12:19:30 -0400 Received: from verein.lst.de ([213.95.11.210]:33285) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O5LbE-000504-Ur for qemu-devel@nongnu.org; Fri, 23 Apr 2010 12:19:29 -0400 Date: Fri, 23 Apr 2010 18:19:20 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH] block: reject O_RDWR open for read-only images Message-ID: <20100423161920.GA1655@lst.de> References: <20100407115753.GB12452@lst.de> <4BBC7B62.7060607@redhat.com> <4BD1C625.50602@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BD1C625.50602@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Christoph Hellwig , qemu-devel@nongnu.org On Fri, Apr 23, 2010 at 06:09:09PM +0200, Kevin Wolf wrote: > Christoph, what about this one? It's still in the block branch, but I > have excluded it from first pull request round because these questions > are still open. > > What should I do with it? Drop it, wait for a new version or keep it as > it is? If you're not going to drop it, I'd definitely like to hear more > opinions on the compatibility thing before proposing it for a merge in a > pull request. Drop it for now. I agree on the centralization so I will do it. Then we can decide if we want to implement the enforcement in the central place ontop of it.