From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O5POU-00060c-S0
	for qemu-devel@nongnu.org; Fri, 23 Apr 2010 16:22:34 -0400
Received: from [140.186.70.92] (port=36621 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O5POQ-0005xp-GO
	for qemu-devel@nongnu.org; Fri, 23 Apr 2010 16:22:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <ryanh@us.ibm.com>) id 1O5POO-0006Hh-BC
	for qemu-devel@nongnu.org; Fri, 23 Apr 2010 16:22:30 -0400
Received: from e4.ny.us.ibm.com ([32.97.182.144]:60869)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <ryanh@us.ibm.com>) id 1O5POO-0006H9-81
	for qemu-devel@nongnu.org; Fri, 23 Apr 2010 16:22:28 -0400
Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116])
	by e4.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id o3NKAKx6007590
	for <qemu-devel@nongnu.org>; Fri, 23 Apr 2010 16:10:20 -0400
Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])
	by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	o3NKMN7H1171484
	for <qemu-devel@nongnu.org>; Fri, 23 Apr 2010 16:22:23 -0400
Received: from d01av04.pok.ibm.com (loopback [127.0.0.1])
	by d01av04.pok.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id
	o3NKMMt7007876
	for <qemu-devel@nongnu.org>; Fri, 23 Apr 2010 16:22:22 -0400
Date: Fri, 23 Apr 2010 15:22:14 -0500
From: Ryan Harper <ryanh@us.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 26/26] block: Free iovec arrays allocated by
	multiwrite_merge()
Message-ID: <20100423202214.GA14379@us.ibm.com>
References: <1272036658-26776-1-git-send-email-kwolf@redhat.com>
	<1272036658-26776-27-git-send-email-kwolf@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1272036658-26776-27-git-send-email-kwolf@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: aliguori@linux.vnet.ibm.com, qemu-devel@nongnu.org

* Kevin Wolf <kwolf@redhat.com> [2010-04-23 11:29]:
> From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> 
> A new iovec array is allocated when creating a merged write request.
> This patch ensures that the iovec array is deleted in addition to its
> qiov owner.
> 

Submit for [STABLE] ?

> Reported-by: Leszek Urbanski <tygrys@moo.pl>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/block.c b/block.c
> index 12cf434..7974215 100644
> --- a/block.c
> +++ b/block.c
> @@ -1739,6 +1739,9 @@ static void multiwrite_user_cb(MultiwriteCB *mcb)
> 
>      for (i = 0; i < mcb->num_callbacks; i++) {
>          mcb->callbacks[i].cb(mcb->callbacks[i].opaque, mcb->error);
> +        if (mcb->callbacks[i].free_qiov) {
> +            qemu_iovec_destroy(mcb->callbacks[i].free_qiov);
> +        }
>          qemu_free(mcb->callbacks[i].free_qiov);
>          qemu_vfree(mcb->callbacks[i].free_buf);
>      }
> -- 
> 1.6.6.1
> 
> 

-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh@us.ibm.com