qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jamie Lokier <jamie@shareable.org>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: "Andreas Färber" <andreas.faerber@web.de>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Re: Bug#573439: qemu-kvm: fail to set hdd serial number
Date: Mon, 26 Apr 2010 12:48:51 +0100	[thread overview]
Message-ID: <20100426114851.GA16976@shareable.org> (raw)
In-Reply-To: <4BD4A781.1020904@msgid.tls.msk.ru>

Michael Tokarev wrote:
> 24.04.2010 17:05, Andreas Färber wrote:
> >Am 22.04.2010 um 11:40 schrieb Michael Tokarev:
> >
> >>11.03.2010 18:34, Michael Tokarev wrote:
> >>[]
> >>>>On version 0.12.3, -drive serial=XXX option does not work.
> >>>>Below patch fixes it. 'serial' is pointer, not array.
> >>>>
> >>>>
> >>>>--- qemu-kvm-0.12.3+dfsg/vl.c 2010-02-26 11:34:00.000000000 +0900
> >>>>+++ qemu-kvm-0.12.3+dfsg.old/vl.c 2010-03-11 02:26:00.134217787 +0900
> >[...]
> >
> >>Folks, can we please add this trivial one-liner to -stable or something?
> >>It has been one and a half months since it has been fixed in debian...
> >
> >Try submitting it as a proper Git patch with summary so that it can be
> >applied to master first; if it's already in master, post the commit id
> >so it can be cherry-picked. Also, mark the subject as [STABLE] or [0.12]
> >or something for Anthony to find it.
> 
> Well, It's not that difficult to carry it in the debian package.
> Hopefully other distros will follow (the ones who are not already),
> so that support requests in #kvm@freenode wont mention that again.

It would be nice for such trivial fixes to be committed to the stable
branch for those of us compiling stable versions from source.

Especially with so many guest regressions lately, so that keeping
multiple qemu versions around is an unfortunate necessity for the time
being.

-- Jamie

      reply	other threads:[~2010-04-26 11:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20100311.234200.145758949990685830.kou1.ono@gmail.com>
2010-03-11 15:34 ` [Qemu-devel] Re: Bug#573439: qemu-kvm: fail to set hdd serial number Michael Tokarev
2010-04-22  9:40   ` Michael Tokarev
2010-04-24 13:05     ` Andreas Färber
2010-04-25 20:35       ` Michael Tokarev
2010-04-26 11:48         ` Jamie Lokier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100426114851.GA16976@shareable.org \
    --to=jamie@shareable.org \
    --cc=andreas.faerber@web.de \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).