From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O6MoB-00012m-Rr for qemu-devel@nongnu.org; Mon, 26 Apr 2010 07:49:03 -0400 Received: from [140.186.70.92] (port=58907 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O6MoA-00012e-D3 for qemu-devel@nongnu.org; Mon, 26 Apr 2010 07:49:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O6Mo8-00075N-IT for qemu-devel@nongnu.org; Mon, 26 Apr 2010 07:49:02 -0400 Received: from mail2.shareable.org ([80.68.89.115]:35893) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O6Mo8-00074E-E1 for qemu-devel@nongnu.org; Mon, 26 Apr 2010 07:49:00 -0400 Date: Mon, 26 Apr 2010 12:48:51 +0100 From: Jamie Lokier Subject: Re: [Qemu-devel] Re: Bug#573439: qemu-kvm: fail to set hdd serial number Message-ID: <20100426114851.GA16976@shareable.org> References: <20100311.234200.145758949990685830.kou1.ono@gmail.com> <4B990D78.6050708@msgid.tls.msk.ru> <4BD01972.9030006@msgid.tls.msk.ru> <4BD4A781.1020904@msgid.tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4BD4A781.1020904@msgid.tls.msk.ru> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: Andreas =?iso-8859-1?Q?F=E4rber?= , qemu-devel Michael Tokarev wrote: > 24.04.2010 17:05, Andreas Färber wrote: > >Am 22.04.2010 um 11:40 schrieb Michael Tokarev: > > > >>11.03.2010 18:34, Michael Tokarev wrote: > >>[] > >>>>On version 0.12.3, -drive serial=XXX option does not work. > >>>>Below patch fixes it. 'serial' is pointer, not array. > >>>> > >>>> > >>>>--- qemu-kvm-0.12.3+dfsg/vl.c 2010-02-26 11:34:00.000000000 +0900 > >>>>+++ qemu-kvm-0.12.3+dfsg.old/vl.c 2010-03-11 02:26:00.134217787 +0900 > >[...] > > > >>Folks, can we please add this trivial one-liner to -stable or something? > >>It has been one and a half months since it has been fixed in debian... > > > >Try submitting it as a proper Git patch with summary so that it can be > >applied to master first; if it's already in master, post the commit id > >so it can be cherry-picked. Also, mark the subject as [STABLE] or [0.12] > >or something for Anthony to find it. > > Well, It's not that difficult to carry it in the debian package. > Hopefully other distros will follow (the ones who are not already), > so that support requests in #kvm@freenode wont mention that again. It would be nice for such trivial fixes to be committed to the stable branch for those of us compiling stable versions from source. Especially with so many guest regressions lately, so that keeping multiple qemu versions around is an unfortunate necessity for the time being. -- Jamie