[Qemu-devel] Re: Bug#573439: qemu-kvm: fail to set hdd serial number

[Qemu-devel] Re: Bug#573439: qemu-kvm: fail to set hdd serial number

[Michael Tokarev]

tags 573439 + upstream patch pending
thanks

Kouichi ONO wrote:
> Package: qemu-kvm
> Version: 0.12.3+dfsg-3
> Severity: normal
> 
> Hello,
> 
> On version 0.12.3, -drive serial=XXX option does not work.
> Below patch fixes it. 'serial' is pointer, not array.
> 
> 
> --- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
> +++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
> @@ -2397,7 +2397,7 @@
>      dinfo->on_write_error = on_write_error;
>      dinfo->opts = opts;
>      if (serial)
> -        strncpy(dinfo->serial, serial, sizeof(serial));
> +        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
>      QTAILQ_INSERT_TAIL(&drives, dinfo, next);
>      if (is_extboot) {
>          extboot_drive = dinfo;

Good catch!  Thank you for the excellent bug report with
the patch.  It is this way even in upstream qemu, not only
in qemu-kvm...  So forwarding this to upstream too.

The patch will in in the next release of the Debian package.

Thanks!

/mjt

Re: [Qemu-devel] Re: Bug#573439: qemu-kvm: fail to set hdd serial number

[Michael Tokarev]

11.03.2010 18:34, Michael Tokarev wrote:
[]
>> On version 0.12.3, -drive serial=XXX option does not work.
>> Below patch fixes it. 'serial' is pointer, not array.
>>
>>
>> --- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
>> +++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
>> @@ -2397,7 +2397,7 @@
>>       dinfo->on_write_error = on_write_error;
>>       dinfo->opts = opts;
>>       if (serial)
>> -        strncpy(dinfo->serial, serial, sizeof(serial));
>> +        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
>>       QTAILQ_INSERT_TAIL(&drives, dinfo, next);
>>       if (is_extboot) {
>>           extboot_drive = dinfo;

Folks, can we please add this trivial one-liner to -stable or something?
It has been one and a half months since it has been fixed in debian...

Thanks!

/mjt

Re: [Qemu-devel] Re: Bug#573439: qemu-kvm: fail to set hdd serial number

[Andreas Färber]

Am 22.04.2010 um 11:40 schrieb Michael Tokarev:

> 11.03.2010 18:34, Michael Tokarev wrote:
> []
>>> On version 0.12.3, -drive serial=XXX option does not work.
>>> Below patch fixes it. 'serial' is pointer, not array.
>>>
>>>
>>> --- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
>>> +++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787  
>>> +0900
[...]

> Folks, can we please add this trivial one-liner to -stable or  
> something?
> It has been one and a half months since it has been fixed in debian...

Try submitting it as a proper Git patch with summary so that it can be  
applied to master first; if it's already in master, post the commit id  
so it can be cherry-picked. Also, mark the subject as [STABLE] or  
[0.12] or something for Anthony to find it.

Andreas

Re: [Qemu-devel] Re: Bug#573439: qemu-kvm: fail to set hdd serial number

[Michael Tokarev]

24.04.2010 17:05, Andreas Färber wrote:
> Am 22.04.2010 um 11:40 schrieb Michael Tokarev:
>
>> 11.03.2010 18:34, Michael Tokarev wrote:
>> []
>>>> On version 0.12.3, -drive serial=XXX option does not work.
>>>> Below patch fixes it. 'serial' is pointer, not array.
>>>>
>>>>
>>>> --- qemu-kvm-0.12.3+dfsg/vl.c 2010-02-26 11:34:00.000000000 +0900
>>>> +++ qemu-kvm-0.12.3+dfsg.old/vl.c 2010-03-11 02:26:00.134217787 +0900
> [...]
>
>> Folks, can we please add this trivial one-liner to -stable or something?
>> It has been one and a half months since it has been fixed in debian...
>
> Try submitting it as a proper Git patch with summary so that it can be
> applied to master first; if it's already in master, post the commit id
> so it can be cherry-picked. Also, mark the subject as [STABLE] or [0.12]
> or something for Anthony to find it.

Well, It's not that difficult to carry it in the debian package.
Hopefully other distros will follow (the ones who are not already),
so that support requests in #kvm@freenode wont mention that again.

Thanks.

/mjt

Re: [Qemu-devel] Re: Bug#573439: qemu-kvm: fail to set hdd serial number

[Jamie Lokier]

Michael Tokarev wrote:
> 24.04.2010 17:05, Andreas Färber wrote:
> >Am 22.04.2010 um 11:40 schrieb Michael Tokarev:
> >
> >>11.03.2010 18:34, Michael Tokarev wrote:
> >>[]
> >>>>On version 0.12.3, -drive serial=XXX option does not work.
> >>>>Below patch fixes it. 'serial' is pointer, not array.
> >>>>
> >>>>
> >>>>--- qemu-kvm-0.12.3+dfsg/vl.c 2010-02-26 11:34:00.000000000 +0900
> >>>>+++ qemu-kvm-0.12.3+dfsg.old/vl.c 2010-03-11 02:26:00.134217787 +0900
> >[...]
> >
> >>Folks, can we please add this trivial one-liner to -stable or something?
> >>It has been one and a half months since it has been fixed in debian...
> >
> >Try submitting it as a proper Git patch with summary so that it can be
> >applied to master first; if it's already in master, post the commit id
> >so it can be cherry-picked. Also, mark the subject as [STABLE] or [0.12]
> >or something for Anthony to find it.
> 
> Well, It's not that difficult to carry it in the debian package.
> Hopefully other distros will follow (the ones who are not already),
> so that support requests in #kvm@freenode wont mention that again.

It would be nice for such trivial fixes to be committed to the stable
branch for those of us compiling stable versions from source.

Especially with so many guest regressions lately, so that keeping
multiple qemu versions around is an unfortunate necessity for the time
being.

-- Jamie