From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O6SwP-0004dK-0a
	for qemu-devel@nongnu.org; Mon, 26 Apr 2010 14:21:57 -0400
Received: from [140.186.70.92] (port=60276 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O6SwN-0004a2-KP
	for qemu-devel@nongnu.org; Mon, 26 Apr 2010 14:21:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1O6SwD-0002tF-OE
	for qemu-devel@nongnu.org; Mon, 26 Apr 2010 14:21:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:26525)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1O6SwD-0002t3-Fp
	for qemu-devel@nongnu.org; Mon, 26 Apr 2010 14:21:45 -0400
Received: from int-mx05.intmail.prod.int.phx2.redhat.com
	(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3QILi9G020490
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 26 Apr 2010 14:21:44 -0400
Date: Mon, 26 Apr 2010 15:21:37 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20100426152137.34ee9fbe@redhat.com>
In-Reply-To: <m3vdbexg5o.fsf@blackfin.pond.sub.org>
References: <m3vdbexg5o.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] Revert "PCI: Convert pci_device_hot_add()
	to QObject"
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, 26 Apr 2010 19:44:19 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> We don't want pci_add in QMP.  Use device_add instead.
> 
> This reverts commit 7a344f7ac7bb651d0556a933ed8060d3a9e5d949.
> 
> Conflicts:
> 
> 	hw/pci-hotplug.c
> 	sysemu.h
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

 The patch looks ok and I'm assuming that device_add can do everything
pci_add does, right?