From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O70Ki-0000RT-Rp for qemu-devel@nongnu.org; Wed, 28 Apr 2010 02:01:16 -0400 Received: from [140.186.70.92] (port=38553 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O70Kb-0000QE-0x for qemu-devel@nongnu.org; Wed, 28 Apr 2010 02:01:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O70KZ-00074a-9R for qemu-devel@nongnu.org; Wed, 28 Apr 2010 02:01:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55759) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O70KZ-00074O-1g for qemu-devel@nongnu.org; Wed, 28 Apr 2010 02:01:07 -0400 Date: Wed, 28 Apr 2010 09:57:49 +0530 From: Amit Shah Message-ID: <20100428042749.GA27314@amit-x200.redhat.com> References: <1272371652-23087-1-git-send-email-amit.shah@redhat.com> <1272371652-23087-2-git-send-email-amit.shah@redhat.com> <1272371652-23087-3-git-send-email-amit.shah@redhat.com> <1272371652-23087-4-git-send-email-amit.shah@redhat.com> <1272371652-23087-5-git-send-email-amit.shah@redhat.com> <1272371652-23087-6-git-send-email-amit.shah@redhat.com> <4BD720BC.3090503@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BD720BC.3090503@codemonkey.ws> Subject: [Qemu-devel] Re: [PATCH v6 05/18] virtio-serial: Use control messages to notify guest of new ports List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu list , Juan Quintela On (Tue) Apr 27 2010 [12:37:00], Anthony Liguori wrote: > On 04/27/2010 07:33 AM, Amit Shah wrote: >> Allow the port 'id's to be set by a user on the command line. This is >> needed by management apps that will want a stable port numbering scheme >> for hot-plug/unplug and migration. >> >> Since the port numbers are shared with the guest (to identify ports in >> control messages), we just send a control message to the guest >> indicating addition of new ports (hot-plug) or notifying the guest of >> the available ports when the guest sends us a DEVICE_READY control >> message. >> >> Signed-off-by: Amit Shah >> > > If you're introducing a new message type, don't you need to negotiate > that feature with the guest? Since we didn't have any kernel or qemu released with the older ABI, changing the numbers isn't a bad thing (we disabled multiport support for 2.6.34 because of this). Amit