Re: [Qemu-devel] Re: [PATCH 06/10] kvm: remove explicit kvm_arch_reset_vcpu from kvm_init_vcpu

[Marcelo Tosatti <mtosatti@redhat.com>]

On Wed, Apr 28, 2010 at 10:39:06AM -0500, Anthony Liguori wrote:
> On 04/26/2010 12:59 PM, Marcelo Tosatti wrote:
> >This is now done via the initialization's qemu_system_reset call.
> >
> >Signed-off-by: Avi Kivity<avi@redhat.com>
> >---
> >  kvm-all.c |    1 -
> >  1 files changed, 0 insertions(+), 1 deletions(-)
> >
> >diff --git a/kvm-all.c b/kvm-all.c
> >index 9c8aa7d..eabb097 100644
> >--- a/kvm-all.c
> >+++ b/kvm-all.c
> >@@ -208,7 +208,6 @@ int kvm_init_vcpu(CPUState *env)
> >      ret = kvm_arch_init_vcpu(env);
> >      if (ret == 0) {
> >          qemu_register_reset(kvm_reset_vcpu, env);
> >-        kvm_arch_reset_vcpu(env);
> >      }
> >  err:
> >      return ret;
> 
> This breaks -enable-kvm in upstream qemu.  No progress is ever made
> in the guest.

These patches have been autotested, and just confirmed manually that    
this patch does not break -enable-kvm (as the reset handler is now 
called through the notifier).

What is your qemu command line?