From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O7Ac5-0005lF-91
	for qemu-devel@nongnu.org; Wed, 28 Apr 2010 12:59:53 -0400
Received: from [140.186.70.92] (port=33995 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O7Ac3-0005kz-7A
	for qemu-devel@nongnu.org; Wed, 28 Apr 2010 12:59:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <mtosatti@redhat.com>) id 1O7Ac1-0006VT-MH
	for qemu-devel@nongnu.org; Wed, 28 Apr 2010 12:59:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:31606)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <mtosatti@redhat.com>) id 1O7Ac1-0006V3-Eb
	for qemu-devel@nongnu.org; Wed, 28 Apr 2010 12:59:49 -0400
Date: Wed, 28 Apr 2010 13:42:01 -0300
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH 06/10] kvm: remove explicit
	kvm_arch_reset_vcpu from kvm_init_vcpu
Message-ID: <20100428164201.GE18168@amt.cnet>
References: <cover.1272304746.git.mtosatti@redhat.com>
	<1e7180606d206cc9882d4545cbf1aed29fad8088.1272304746.git.mtosatti@redhat.com>
	<4BD8569A.1030205@codemonkey.ws> <20100428162214.GA18168@amt.cnet>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100428162214.GA18168@amt.cnet>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>

On Wed, Apr 28, 2010 at 01:22:14PM -0300, Marcelo Tosatti wrote:
> On Wed, Apr 28, 2010 at 10:39:06AM -0500, Anthony Liguori wrote:
> > On 04/26/2010 12:59 PM, Marcelo Tosatti wrote:
> > >This is now done via the initialization's qemu_system_reset call.
> > >
> > >Signed-off-by: Avi Kivity<avi@redhat.com>
> > >---
> > >  kvm-all.c |    1 -
> > >  1 files changed, 0 insertions(+), 1 deletions(-)
> > >
> > >diff --git a/kvm-all.c b/kvm-all.c
> > >index 9c8aa7d..eabb097 100644
> > >--- a/kvm-all.c
> > >+++ b/kvm-all.c
> > >@@ -208,7 +208,6 @@ int kvm_init_vcpu(CPUState *env)
> > >      ret = kvm_arch_init_vcpu(env);
> > >      if (ret == 0) {
> > >          qemu_register_reset(kvm_reset_vcpu, env);
> > >-        kvm_arch_reset_vcpu(env);
> > >      }
> > >  err:
> > >      return ret;
> > 
> > This breaks -enable-kvm in upstream qemu.  No progress is ever made
> > in the guest.
> 
> These patches have been autotested, and just confirmed manually that    
> this patch does not break -enable-kvm (as the reset handler is now 
> called through the notifier).
> 
> What is your qemu command line?

Just drop it please.