[Qemu-devel] Re: [PATCH 1/2] block: Add wr_highest_sector blockstat

[Luiz Capitulino <lcapitulino@redhat.com>]

On Thu, 29 Apr 2010 12:00:45 +0200
Kevin Wolf <kwolf@redhat.com> wrote:

> >>  /**
> >>   * bdrv_info_stats(): show block device statistics
> >>   *
> >> @@ -1544,19 +1580,34 @@ void bdrv_stats_print(Monitor *mon, const QObject *data)
> >>   *     - "wr_bytes": bytes written
> >>   *     - "rd_operations": read operations
> >>   *     - "wr_operations": write operations
> >> - * 
> >> + *     - "wr_highest_offset": Highest offset of a sector written since the
> >> + *       BlockDriverState has been opened
> >> + *     - "parent": Contains recursively the statistics of the underlying
> >> + *       protocol (e.g. the host file for a qcow2 image). If there is no
> >> + *       underlying protocol, this field is omitted.
> > 
> >  Looks like you are not pushing 'protocol', we already have 'format'
> > though (not sure if they overlap).
> 
> You're talking about a new key 'protocol'? I'm not sure what it should
> describe, to be honest.

 I thought I read somewhere you were going to have a 'protocol' key as well
(in addition to 'wr_highest_offset' and 'parent') but looks like I was just
confused.

 Sorry for the noise.