From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O7XbN-0004VL-8X
	for qemu-devel@nongnu.org; Thu, 29 Apr 2010 13:32:41 -0400
Received: from [140.186.70.92] (port=45195 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O7XbL-0004Ud-NO
	for qemu-devel@nongnu.org; Thu, 29 Apr 2010 13:32:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1O7XbK-0005Pr-26
	for qemu-devel@nongnu.org; Thu, 29 Apr 2010 13:32:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1029)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1O7XbJ-0005Pg-Qs
	for qemu-devel@nongnu.org; Thu, 29 Apr 2010 13:32:38 -0400
Date: Thu, 29 Apr 2010 14:32:29 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20100429143229.6675528b@redhat.com>
In-Reply-To: <4BD958CD.9080609@redhat.com>
References: <1272470181-15846-1-git-send-email-kwolf@redhat.com>
	<1272470181-15846-2-git-send-email-kwolf@redhat.com>
	<20100428143159.47b831b2@redhat.com> <4BD958CD.9080609@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 1/2] block: Add wr_highest_sector blockstat
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: dlaor@redhat.com, qemu-devel@nongnu.org, avi@redhat.com, danken@redhat.com

On Thu, 29 Apr 2010 12:00:45 +0200
Kevin Wolf <kwolf@redhat.com> wrote:

> >>  /**
> >>   * bdrv_info_stats(): show block device statistics
> >>   *
> >> @@ -1544,19 +1580,34 @@ void bdrv_stats_print(Monitor *mon, const QObject *data)
> >>   *     - "wr_bytes": bytes written
> >>   *     - "rd_operations": read operations
> >>   *     - "wr_operations": write operations
> >> - * 
> >> + *     - "wr_highest_offset": Highest offset of a sector written since the
> >> + *       BlockDriverState has been opened
> >> + *     - "parent": Contains recursively the statistics of the underlying
> >> + *       protocol (e.g. the host file for a qcow2 image). If there is no
> >> + *       underlying protocol, this field is omitted.
> > 
> >  Looks like you are not pushing 'protocol', we already have 'format'
> > though (not sure if they overlap).
> 
> You're talking about a new key 'protocol'? I'm not sure what it should
> describe, to be honest.

 I thought I read somewhere you were going to have a 'protocol' key as well
(in addition to 'wr_highest_offset' and 'parent') but looks like I was just
confused.

 Sorry for the noise.