* [Qemu-devel] [PATCH] Add KVM CFLAGS to vhost build
@ 2010-04-06 11:31 Jan Kiszka
2010-05-03 17:03 ` [Qemu-devel] " Jan Kiszka
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jan Kiszka @ 2010-04-06 11:31 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel, Michael S. Tsirkin
The configure test of vhost uses KVM CFLAGS, so the build must use them
as well. Otherwise we specifically miss what --kerneldir provides.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
Makefile.target | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile.target b/Makefile.target
index 45cbe56..6fc3034 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -32,7 +32,7 @@ PROGS=$(QEMU_PROG)
LIBS+=-lm
-kvm.o kvm-all.o: QEMU_CFLAGS+=$(KVM_CFLAGS)
+kvm.o kvm-all.o vhost.o vhost_net.o: QEMU_CFLAGS+=$(KVM_CFLAGS)
config-target.h: config-target.h-timestamp
config-target.h-timestamp: config-target.mak
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Qemu-devel] Re: [PATCH] Add KVM CFLAGS to vhost build
2010-04-06 11:31 [Qemu-devel] [PATCH] Add KVM CFLAGS to vhost build Jan Kiszka
@ 2010-05-03 17:03 ` Jan Kiszka
2010-05-03 17:21 ` Michael S. Tsirkin
2010-05-03 18:05 ` [Qemu-devel] " Anthony Liguori
2 siblings, 0 replies; 4+ messages in thread
From: Jan Kiszka @ 2010-05-03 17:03 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel, Michael S. Tsirkin
Jan Kiszka wrote:
> The configure test of vhost uses KVM CFLAGS, so the build must use them
> as well. Otherwise we specifically miss what --kerneldir provides.
>
Ping.
Jan
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> Makefile.target | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index 45cbe56..6fc3034 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -32,7 +32,7 @@ PROGS=$(QEMU_PROG)
>
> LIBS+=-lm
>
> -kvm.o kvm-all.o: QEMU_CFLAGS+=$(KVM_CFLAGS)
> +kvm.o kvm-all.o vhost.o vhost_net.o: QEMU_CFLAGS+=$(KVM_CFLAGS)
>
> config-target.h: config-target.h-timestamp
> config-target.h-timestamp: config-target.mak
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] Re: [PATCH] Add KVM CFLAGS to vhost build
2010-04-06 11:31 [Qemu-devel] [PATCH] Add KVM CFLAGS to vhost build Jan Kiszka
2010-05-03 17:03 ` [Qemu-devel] " Jan Kiszka
@ 2010-05-03 17:21 ` Michael S. Tsirkin
2010-05-03 18:05 ` [Qemu-devel] " Anthony Liguori
2 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2010-05-03 17:21 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Anthony Liguori, qemu-devel
On Tue, Apr 06, 2010 at 01:31:29PM +0200, Jan Kiszka wrote:
> The configure test of vhost uses KVM CFLAGS, so the build must use them
> as well. Otherwise we specifically miss what --kerneldir provides.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> Makefile.target | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index 45cbe56..6fc3034 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -32,7 +32,7 @@ PROGS=$(QEMU_PROG)
>
> LIBS+=-lm
>
> -kvm.o kvm-all.o: QEMU_CFLAGS+=$(KVM_CFLAGS)
> +kvm.o kvm-all.o vhost.o vhost_net.o: QEMU_CFLAGS+=$(KVM_CFLAGS)
>
> config-target.h: config-target.h-timestamp
> config-target.h-timestamp: config-target.mak
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Add KVM CFLAGS to vhost build
2010-04-06 11:31 [Qemu-devel] [PATCH] Add KVM CFLAGS to vhost build Jan Kiszka
2010-05-03 17:03 ` [Qemu-devel] " Jan Kiszka
2010-05-03 17:21 ` Michael S. Tsirkin
@ 2010-05-03 18:05 ` Anthony Liguori
2 siblings, 0 replies; 4+ messages in thread
From: Anthony Liguori @ 2010-05-03 18:05 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-devel, Michael S. Tsirkin
On 04/06/2010 06:31 AM, Jan Kiszka wrote:
> The configure test of vhost uses KVM CFLAGS, so the build must use them
> as well. Otherwise we specifically miss what --kerneldir provides.
>
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> Makefile.target | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index 45cbe56..6fc3034 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -32,7 +32,7 @@ PROGS=$(QEMU_PROG)
>
> LIBS+=-lm
>
> -kvm.o kvm-all.o: QEMU_CFLAGS+=$(KVM_CFLAGS)
> +kvm.o kvm-all.o vhost.o vhost_net.o: QEMU_CFLAGS+=$(KVM_CFLAGS)
>
> config-target.h: config-target.h-timestamp
> config-target.h-timestamp: config-target.mak
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-05-03 18:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-06 11:31 [Qemu-devel] [PATCH] Add KVM CFLAGS to vhost build Jan Kiszka
2010-05-03 17:03 ` [Qemu-devel] " Jan Kiszka
2010-05-03 17:21 ` Michael S. Tsirkin
2010-05-03 18:05 ` [Qemu-devel] " Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).