qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Paul Brook <paul@codesourcery.com>,
	qemu list <qemu-devel@nongnu.org>,
	Juan Quintela <quintela@redhat.com>
Subject: [Qemu-devel] Re: [PATCH v4 3/5] char: unix/tcp: Add a non-blocking write handler
Date: Tue, 4 May 2010 13:26:23 +0530	[thread overview]
Message-ID: <20100504075623.GA8136@amit-x200.redhat.com> (raw)
In-Reply-To: <4BDFD008.3000106@redhat.com>

On (Tue) May 04 2010 [09:43:04], Gerd Hoffmann wrote:
> On 05/04/10 09:17, Amit Shah wrote:
>> Add a non-blocking write handler that can return with -EAGAIN to the
>> caller and also callback when the socket becomes writable.
>>
>> Non-blocking writes are only enabled for sockets that are opened in
>> non-blocking mode and only for callers that have registered a callback
>> handler for resuming writes.
>
> The logic will be pretty much the same for all filehandle-based backends  
> on unix.  So maybe create some helper functions, so implementing  
> $backend_chr_write_unblocked can be done with just three lines of code?

Yes, that's the next step. Let's push this for now and do that in a
later patch series?

		Amit

  reply	other threads:[~2010-05-04 12:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-04  7:17 [Qemu-devel] [PATCH v4 0/5] char: non-blocking writes, virtio-console flow control Amit Shah
2010-05-04  7:17 ` [Qemu-devel] [PATCH v4 1/5] char: Let writers know how much data was written in case of errors Amit Shah
2010-05-04  7:17   ` [Qemu-devel] [PATCH v4 2/5] char: Add qemu_chr_write_nb() for nonblocking writes Amit Shah
2010-05-04  7:17     ` [Qemu-devel] [PATCH v4 3/5] char: unix/tcp: Add a non-blocking write handler Amit Shah
2010-05-04  7:17       ` [Qemu-devel] [PATCH v4 4/5] virtio-console: Factor out common init between console and generic ports Amit Shah
2010-05-04  7:17         ` [Qemu-devel] [PATCH v4 5/5] virtio-console: Throttle virtio-serial-bus if we can't consume any more guest data Amit Shah
2010-05-04  7:43       ` [Qemu-devel] Re: [PATCH v4 3/5] char: unix/tcp: Add a non-blocking write handler Gerd Hoffmann
2010-05-04  7:56         ` Amit Shah [this message]
2010-05-04  8:13           ` Gerd Hoffmann
2010-05-04  7:38     ` [Qemu-devel] Re: [PATCH v4 2/5] char: Add qemu_chr_write_nb() for nonblocking writes Gerd Hoffmann
2010-05-04  7:58       ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100504075623.GA8136@amit-x200.redhat.com \
    --to=amit.shah@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).