From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O9EOR-0007Ez-AG
	for qemu-devel@nongnu.org; Tue, 04 May 2010 05:26:19 -0400
Received: from [140.186.70.92] (port=42757 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O9EOP-0007EB-JK
	for qemu-devel@nongnu.org; Tue, 04 May 2010 05:26:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <berrange@redhat.com>) id 1O9EOI-0000Vo-99
	for qemu-devel@nongnu.org; Tue, 04 May 2010 05:26:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:31919)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <berrange@redhat.com>) id 1O9EOI-0000VP-1t
	for qemu-devel@nongnu.org; Tue, 04 May 2010 05:26:10 -0400
Date: Tue, 4 May 2010 10:26:04 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH] Revert "PCI: Convert
	pci_device_hot_add() to QObject"
Message-ID: <20100504092604.GC7685@redhat.com>
References: <m3vdbexg5o.fsf@blackfin.pond.sub.org>
	<20100426152137.34ee9fbe@redhat.com>
	<m3mxwhz629.fsf@blackfin.pond.sub.org>
	<4BDF010B.6090007@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4BDF010B.6090007@codemonkey.ws>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Luiz Capitulino <lcapitulino@redhat.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

On Mon, May 03, 2010 at 11:59:55AM -0500, Anthony Liguori wrote:
> On 05/03/2010 04:29 AM, Markus Armbruster wrote:
> >Why am I proposing to remove pci_add from QMP before its replacement is
> >ready?  I want it out sooner rather than later, because it isn't fully
> >functional (errors and drive_add are missing), and we do not plan to
> >complete the job.  In other words, it's not really usable over QMP now,
> >and it's not what we want for QMP anyway.  Since we don't want it to be
> >used over QMP, we should take it out, not leave it around as a trap for
> >the uninitiated.
> >
> >Anyway, I'll respin with a more verbose commit message, and I'll throw
> >in the buddy patch Revert "monitor: Convert do_pci_device_hot_remove()
> >to QObject".
> >   
> 
> Does libvirt not use pci_add with QMP?

As of QEMU 0.12, libvirt uses -device syntax for everything.

As of QEMU 0.13, libvirt will use QMP for everything (if compiled with
the libyajl JSON library - otherwise text mode only).

When -device is in use, we use device_add exclusively. Therefore,
we will have no need for pci_add & friends when using QMP.


Regards,
Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|