From: Amit Shah <amit.shah@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Paul Brook <paul@codesourcery.com>,
qemu list <qemu-devel@nongnu.org>,
Juan Quintela <quintela@redhat.com>
Subject: [Qemu-devel] Re: [PATCH v5 3/6] char: Let writers know how much data was written in case of errors
Date: Tue, 4 May 2010 17:01:51 +0530 [thread overview]
Message-ID: <20100504113151.GD8136@amit-x200.redhat.com> (raw)
In-Reply-To: <4BE0040A.3020906@redhat.com>
On (Tue) May 04 2010 [13:24:58], Gerd Hoffmann wrote:
>> @@ -531,8 +534,12 @@ static int unix_write(int fd, const uint8_t *buf, int len1)
>> while (len> 0) {
>> ret = write(fd, buf, len);
>> if (ret< 0) {
>> - if (errno != EINTR&& errno != EAGAIN)
>> + if (len1 - len) {
>> + return len1 - len;
>> + }
>> + if (errno != EINTR&& errno != EAGAIN) {
>> return -1;
>> + }
>
> This makes unix_write pass -EINTR up to the caller which it didn't before.
Only on partial writes. Should be OK, no?
Amit
next prev parent reply other threads:[~2010-05-04 11:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 10:52 [Qemu-devel] [PATCH v5 0/6] char: non-blocking writes, virtio-console flow control Amit Shah
2010-05-04 10:52 ` [Qemu-devel] [PATCH v5 1/6] virtio-console: Factor out common init between console and generic ports Amit Shah
2010-05-04 10:52 ` [Qemu-devel] [PATCH v5 2/6] char: Add a QemuChrHandlers struct to initialise chardev handlers Amit Shah
2010-05-04 10:52 ` [Qemu-devel] [PATCH v5 3/6] char: Let writers know how much data was written in case of errors Amit Shah
2010-05-04 10:52 ` [Qemu-devel] [PATCH v5 4/6] char: Add qemu_chr_write_nb() for nonblocking writes Amit Shah
2010-05-04 10:52 ` [Qemu-devel] [PATCH v5 5/6] char: unix/tcp: Add a non-blocking write handler Amit Shah
2010-05-04 10:52 ` [Qemu-devel] [PATCH v5 6/6] virtio-console: Throttle virtio-serial-bus if we can't consume any more guest data Amit Shah
2010-05-04 11:24 ` [Qemu-devel] Re: [PATCH v5 3/6] char: Let writers know how much data was written in case of errors Gerd Hoffmann
2010-05-04 11:31 ` Amit Shah [this message]
2010-05-04 13:30 ` Gerd Hoffmann
2010-05-04 20:09 ` [Qemu-devel] [PATCH v5 2/6] char: Add a QemuChrHandlers struct to initialise chardev handlers Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100504113151.GD8136@amit-x200.redhat.com \
--to=amit.shah@redhat.com \
--cc=kraxel@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).