From: Marcelo Tosatti <mtosatti@redhat.com>
To: kvm@vger.kernel.org, qemu-devel@nongnu.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Subject: [Qemu-devel] [patch uq/master 3/9] standardize on qemu_cpu_kick for signalling cpu thread(s)
Date: Tue, 04 May 2010 09:45:21 -0300 [thread overview]
Message-ID: <20100504124634.283705416@redhat.com> (raw)
In-Reply-To: 20100504124518.979470863@redhat.com
[-- Attachment #1: ipi-on-cpu-kick --]
[-- Type: text/plain, Size: 1267 bytes --]
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Index: qemu/cpus.c
===================================================================
--- qemu.orig/cpus.c
+++ qemu/cpus.c
@@ -454,8 +454,7 @@ void qemu_cpu_kick(void *_env)
{
CPUState *env = _env;
qemu_cond_broadcast(env->halt_cond);
- if (kvm_enabled())
- qemu_thread_signal(env->thread, SIG_IPI);
+ qemu_thread_signal(env->thread, SIG_IPI);
}
int qemu_cpu_self(void *_env)
@@ -583,7 +582,6 @@ void pause_all_vcpus(void)
while (penv) {
penv->stop = 1;
- qemu_thread_signal(penv->thread, SIG_IPI);
qemu_cpu_kick(penv);
penv = (CPUState *)penv->next_cpu;
}
@@ -592,7 +590,7 @@ void pause_all_vcpus(void)
qemu_cond_timedwait(&qemu_pause_cond, &qemu_global_mutex, 100);
penv = first_cpu;
while (penv) {
- qemu_thread_signal(penv->thread, SIG_IPI);
+ qemu_cpu_kick(penv);
penv = (CPUState *)penv->next_cpu;
}
}
@@ -605,7 +603,6 @@ void resume_all_vcpus(void)
while (penv) {
penv->stop = 0;
penv->stopped = 0;
- qemu_thread_signal(penv->thread, SIG_IPI);
qemu_cpu_kick(penv);
penv = (CPUState *)penv->next_cpu;
}
next prev parent reply other threads:[~2010-05-04 13:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 12:45 [Qemu-devel] [patch uq/master 0/9] enable smp > 1 and related fixes Marcelo Tosatti
2010-05-04 12:45 ` [Qemu-devel] [patch uq/master 1/9] kvm: set cpu_single_env around KVM_RUN ioctl Marcelo Tosatti
2010-05-04 12:45 ` [Qemu-devel] [patch uq/master 2/9] make SIG_IPI to tcg vcpu thread reliable Marcelo Tosatti
2010-05-04 12:45 ` Marcelo Tosatti [this message]
2010-05-04 12:45 ` [Qemu-devel] [patch uq/master 4/9] port qemu-kvm's on_vcpu code Marcelo Tosatti
2010-05-04 12:45 ` [Qemu-devel] [patch uq/master 5/9] kvm: synchronize state from cpu context Marcelo Tosatti
2010-05-06 11:31 ` [Qemu-devel] " Avi Kivity
2010-05-04 12:45 ` [Qemu-devel] [patch uq/master 6/9] add cpu_is_stopped helper Marcelo Tosatti
2010-05-04 12:45 ` [Qemu-devel] [patch uq/master 7/9] move stop/stopped CPU_COMMON fields after area zeroed by reset Marcelo Tosatti
2010-05-04 12:45 ` [Qemu-devel] [patch uq/master 8/9] kvm: validate context for kvm cpu get/put operations Marcelo Tosatti
2010-05-04 12:45 ` [Qemu-devel] [patch uq/master 9/9] kvm: enable smp > 1 Marcelo Tosatti
2010-05-05 18:24 ` [Qemu-devel] Re: [patch uq/master 0/9] enable smp > 1 and related fixes Anthony Liguori
2010-05-06 11:33 ` Avi Kivity
2010-05-06 11:34 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100504124634.283705416@redhat.com \
--to=mtosatti@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).