From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O9IVf-000298-3F
	for qemu-devel@nongnu.org; Tue, 04 May 2010 09:50:03 -0400
Received: from [140.186.70.92] (port=53031 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O9IVY-0001za-Ui
	for qemu-devel@nongnu.org; Tue, 04 May 2010 09:50:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <mtosatti@redhat.com>) id 1O9IVU-000449-9c
	for qemu-devel@nongnu.org; Tue, 04 May 2010 09:49:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59754)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <mtosatti@redhat.com>) id 1O9IVU-00043q-2K
	for qemu-devel@nongnu.org; Tue, 04 May 2010 09:49:52 -0400
Message-Id: <20100504124634.572348443@redhat.com>
Date: Tue, 04 May 2010 09:45:26 -0300
From: Marcelo Tosatti <mtosatti@redhat.com>
References: <20100504124518.979470863@redhat.com>
Content-Disposition: inline; filename=assert-get-regs
Subject: [Qemu-devel] [patch uq/master 8/9] kvm: validate context for kvm
	cpu get/put operations
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: kvm@vger.kernel.org, qemu-devel@nongnu.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

Validate that KVM vcpu state is only read/written from cpu thread itself
or that cpu is stopped.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

Index: qemu/target-i386/kvm.c
===================================================================
--- qemu.orig/target-i386/kvm.c
+++ qemu/target-i386/kvm.c
@@ -949,6 +949,8 @@ int kvm_arch_put_registers(CPUState *env
 {
     int ret;
 
+    assert(cpu_is_stopped(env) || qemu_cpu_self(env));
+
     ret = kvm_getput_regs(env, 1);
     if (ret < 0)
         return ret;
@@ -991,6 +993,8 @@ int kvm_arch_get_registers(CPUState *env
 {
     int ret;
 
+    assert(cpu_is_stopped(env) || qemu_cpu_self(env));
+
     ret = kvm_getput_regs(env, 0);
     if (ret < 0)
         return ret;