From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O9LaW-0001UQ-3M for qemu-devel@nongnu.org; Tue, 04 May 2010 13:07:16 -0400 Received: from [140.186.70.92] (port=43653 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9LaV-0001U1-0N for qemu-devel@nongnu.org; Tue, 04 May 2010 13:07:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O9LaT-0007Bk-Es for qemu-devel@nongnu.org; Tue, 04 May 2010 13:07:14 -0400 Received: from verein.lst.de ([213.95.11.210]:47417) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9LaT-0007Be-4v for qemu-devel@nongnu.org; Tue, 04 May 2010 13:07:13 -0400 Date: Tue, 4 May 2010 19:07:06 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion Message-ID: <20100504170706.GA21339@lst.de> References: <4BDF3F94.1080608@dlh.net> <4BDFDC44.9030808@redhat.com> <4BE00750.6040804@dlh.net> <4BE01120.30608@redhat.com> <4BE02440.6010802@dlh.net> <4BE028BF.1000603@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BE028BF.1000603@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Peter Lieven , qemu-devel@nongnu.org, kvm@vger.kernel.org On Tue, May 04, 2010 at 04:01:35PM +0200, Kevin Wolf wrote: > Great, I'm going to submit it as a proper patch then. > > Christoph, by now I'm pretty sure it's right, but can you have another > look if this is correct, anyway? It looks correct to me - we really shouldn't update the the fields until bdrv_aio_cancel has returned. In fact we cannot cancel a request more often than we can, so there's a fairly high chance it will complete. Reviewed-by: Christoph Hellwig