From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O9Q8n-0002Ak-9y for qemu-devel@nongnu.org; Tue, 04 May 2010 17:58:57 -0400 Received: from [140.186.70.92] (port=40298 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9Q8l-000284-HQ for qemu-devel@nongnu.org; Tue, 04 May 2010 17:58:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O9Q8j-0000wO-SA for qemu-devel@nongnu.org; Tue, 04 May 2010 17:58:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43208) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9Q8j-0000wC-Ke for qemu-devel@nongnu.org; Tue, 04 May 2010 17:58:53 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o44LwqNq013358 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 May 2010 17:58:52 -0400 Date: Tue, 4 May 2010 18:58:44 -0300 From: Luiz Capitulino Subject: Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc Message-ID: <20100504185844.4d8ffe33@redhat.com> In-Reply-To: References: <1272647018-29771-1-git-send-email-lcapitulino@redhat.com> <1272647018-29771-2-git-send-email-lcapitulino@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: bazulay@redhat.com, juzhang@redhat.com, qemu-devel@nongnu.org On Mon, 03 May 2010 18:24:11 +0200 Markus Armbruster wrote: > > + > > +Example: > > + > > +{ "execute": "migrate", "arguments": { "uri": "tcp:0:4446" } } > > + > > +Notes: > > + > > +(1) The 'query-migrate' command should be used to check migration's progress > > + and final result (this information is provided by the 'status' member) > > +(2) All boolean arguments default to false > > Don't they always default to false? Yes, but I'm not sure if we should make this such a general rule, maybe it should be possible to say what the default is. And we can do that for new commands if we want to. > > +(3) The user Monitor's "detach" argument is invalid in QMP and should not > > + be used > > Then why do we accept it? It's a bug, nevertheless I think it's worth noting it's not accepted.