From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O9OHy-0005vL-MP
	for qemu-devel@nongnu.org; Tue, 04 May 2010 16:00:18 -0400
Received: from [140.186.70.92] (port=49054 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O9OHs-0005nF-LI
	for qemu-devel@nongnu.org; Tue, 04 May 2010 16:00:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <amit.shah@redhat.com>) id 1O9OHr-0000s6-7K
	for qemu-devel@nongnu.org; Tue, 04 May 2010 16:00:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:21400)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <amit.shah@redhat.com>) id 1O9OHr-0000s0-0B
	for qemu-devel@nongnu.org; Tue, 04 May 2010 16:00:11 -0400
Date: Wed, 5 May 2010 01:28:20 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20100504195820.GB1109@amit-x200.redhat.com>
References: <1272997439-9675-1-git-send-email-amit.shah@redhat.com>
	<1272997439-9675-2-git-send-email-amit.shah@redhat.com>
	<1272997439-9675-3-git-send-email-amit.shah@redhat.com>
	<1272997439-9675-4-git-send-email-amit.shah@redhat.com>
	<1272997439-9675-5-git-send-email-amit.shah@redhat.com>
	<1272997439-9675-6-git-send-email-amit.shah@redhat.com>
	<m3wrvj1lzy.fsf@trasno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3wrvj1lzy.fsf@trasno.mitica>
Subject: [Qemu-devel] Re: [PATCH v6 5/6] char: unix/tcp: Add a non-blocking
	write handler
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: Paul Brook <paul@codesourcery.com>, qemu list <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

On (Tue) May 04 2010 [21:54:09], Juan Quintela wrote:
> >  static void tcp_chr_connect(void *opaque)
> >  {
> >      CharDriverState *chr = opaque;
> >      TCPCharDriver *s = chr->opaque;
> > +    IOHandler *write_cb;
> > +    int flags;
> > +    bool nonblock;
> > +
> > +    flags = fcntl(s->fd, F_GETFL);
> > +    if (flags == -1) {
> > +        flags = 0;
> > +    }
> > +    nonblock = flags & O_NONBLOCK;
> > +
> > +    write_cb = NULL;
> > +    chr->nonblock = false;
> > +    if (nonblock && chr->chr_write_unblocked) {
> > +        write_cb = chr->chr_write_unblocked;
> > +        chr->nonblock = true;
> > +    }
> >  
> > +    chr->write_blocked = false;
> >      s->connected = 1;
> >      qemu_set_fd_handler2(s->fd, tcp_chr_read_poll,
> 
> write_cb is a write-only variable, no?

Leftover from previous design.

I'll clean this up in the next series (already applied to my local
branch).

Thanks,
		Amit