From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O9ed7-00055H-RK
	for qemu-devel@nongnu.org; Wed, 05 May 2010 09:27:13 -0400
Received: from [140.186.70.92] (port=55953 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O9ed6-000535-Cp
	for qemu-devel@nongnu.org; Wed, 05 May 2010 09:27:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <amit.shah@redhat.com>) id 1O9ed4-0002nK-S1
	for qemu-devel@nongnu.org; Wed, 05 May 2010 09:27:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55218)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <amit.shah@redhat.com>) id 1O9ed4-0002nE-Kk
	for qemu-devel@nongnu.org; Wed, 05 May 2010 09:27:10 -0400
Date: Wed, 5 May 2010 18:55:20 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20100505132520.GC27194@amit-x200.redhat.com>
References: <1273009170-17530-1-git-send-email-amit.shah@redhat.com>
	<1273009170-17530-2-git-send-email-amit.shah@redhat.com>
	<1273009170-17530-3-git-send-email-amit.shah@redhat.com>
	<4BE16F16.5030601@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4BE16F16.5030601@codemonkey.ws>
Subject: [Qemu-devel] Re: [PATCH v7 2/6] char: Add a QemuChrHandlers struct
	to initialise chardev handlers
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paul Brook <paul@codesourcery.com>, Juan Quintela <quintela@redhat.com>, qemu list <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

On (Wed) May 05 2010 [08:13:58], Anthony Liguori wrote:
> On 05/04/2010 04:39 PM, Amit Shah wrote:
>> Instead of passing each handler in the qemu_add_handlers() function,
>> create a struct of handlers that can be passed to the function instead.
>>
>> Signed-off-by: Amit Shah<amit.shah@redhat.com>


>> -        qemu_chr_add_handlers(chr, gdb_chr_can_receive, gdb_chr_receive,
>> -                              gdb_chr_event, NULL);
>> +        qemu_chr_add_handlers(chr,&gdb_handlers, NULL);
>>       }
>>    
>
> This sort of change isn't a bad one but if we're making this change, we  
> should change the signature of these functions to also take a  
> QemuChrHandlers *.

What do you mean?

> Also, let's drop the qemu_ and Qemu prefixes while we're at it.

In a later series, please. -ETOOMANYRESENDS already..

		Amit