From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O9kPg-00041x-NX for qemu-devel@nongnu.org; Wed, 05 May 2010 15:37:44 -0400 Received: from [140.186.70.92] (port=37575 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9kPf-00040J-Ah for qemu-devel@nongnu.org; Wed, 05 May 2010 15:37:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O9kPd-0006lb-62 for qemu-devel@nongnu.org; Wed, 05 May 2010 15:37:42 -0400 Received: from c.painless.aaisp.net.uk ([81.187.30.53]:51121) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9kPd-0006i9-27 for qemu-devel@nongnu.org; Wed, 05 May 2010 15:37:41 -0400 Received: from zubnet.me.uk ([81.187.243.246] helo=circe) by c.painless.aaisp.net.uk with esmtp (Exim 4.69) (envelope-from ) id 1O9kPS-0003AA-U9 for qemu-devel@nongnu.org; Wed, 05 May 2010 20:37:30 +0100 Date: Wed, 5 May 2010 20:37:16 +0100 From: Stuart Brady Subject: Re: [Qemu-devel] Re: [RFC] [PATCH] add ahci support into qemu Message-ID: <20100505193716.GA5982@zubnet.me.uk> References: <4BDAD1A3.1040906@loongson.cn> <62A72125-4FCF-4B72-82E5-24840460C3D2@suse.de> <4BDD7596.6080207@loongson.cn> <2FC4BB04CF31478F952129939300295C@FSCPC> <4BDF7358.8050101@loongson.cn> <5C35C8A4235E4017B4A83B54858C464E@FSCPC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5C35C8A4235E4017B4A83B54858C464E@FSCPC> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Tue, May 04, 2010 at 10:51:37PM +0200, Sebastian Herbszt wrote: > >diff --git a/hw/pci_ids.h b/hw/pci_ids.h > >index fe7a121..4d4de93 100644 > >--- a/hw/pci_ids.h > >+++ b/hw/pci_ids.h > >@@ -97,3 +97,4 @@ > >#define PCI_DEVICE_ID_INTEL_82371AB 0x7111 > >#define PCI_DEVICE_ID_INTEL_82371AB_2 0x7112 > >#define PCI_DEVICE_ID_INTEL_82371AB_3 0x7113 > >+#define PCI_DEVICE_ID_INTEL_ICH6R_AHCI 0x2652 > > The list is sorted by vendor and device id. This entry should go > after "PCI_DEVICE_ID_INTEL_ESB_9". The naming scheme seems > to be VENDOR_DEVICE_FUNCTION, so i suggest something like > PCI_DEVICE_ID_INTEL_ICH6R_2 or PCI_DEVICE_ID_INTEL_82801FR_2. Linux seems to have called this PCI_DEVICE_ID_INTEL_ICH6_4 at one point. So this should be function 4, no? Cheers, -- Stuart Brady