From: Jamie Lokier <jamie@shareable.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] question on virtio
Date: Thu, 6 May 2010 17:43:31 +0100 [thread overview]
Message-ID: <20100506164331.GF28512@shareable.org> (raw)
In-Reply-To: <20100505110947.GA27872@redhat.com>
Michael S. Tsirkin wrote:
> Hi!
> I see this in virtio_ring.c:
>
> /* Put entry in available array (but don't update avail->idx *
> until they do sync). */
>
> Why is it done this way?
> It seems that updating the index straight away would be simpler, while
> this might allow the host to specilatively look up the buffer and handle
> it, without waiting for the kick.
Even better, if the host updates a location containing which index it
has seen recently, you can avoid the kick entirely during sustained
flows - just like your recent patch to avoid sending irqs to the
guest.
-- Jamie
prev parent reply other threads:[~2010-05-06 16:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 11:09 [Qemu-devel] question on virtio Michael S. Tsirkin
2010-05-05 19:40 ` [Qemu-devel] " Anthony Liguori
2010-05-05 20:59 ` Michael S. Tsirkin
2010-05-06 1:32 ` Rusty Russell
2010-05-06 16:43 ` Jamie Lokier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100506164331.GF28512@shareable.org \
--to=jamie@shareable.org \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).