From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1OAQtM-0006u7-Cs
	for qemu-devel@nongnu.org; Fri, 07 May 2010 12:59:12 -0400
Received: from [140.186.70.92] (port=56159 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OAQtK-0006t1-W5
	for qemu-devel@nongnu.org; Fri, 07 May 2010 12:59:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1OAQtJ-0002yb-A7
	for qemu-devel@nongnu.org; Fri, 07 May 2010 12:59:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:31325)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1OAQtI-0002yN-LC
	for qemu-devel@nongnu.org; Fri, 07 May 2010 12:59:09 -0400
Date: Fri, 7 May 2010 13:59:02 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20100507135902.2753bb4a@redhat.com>
In-Reply-To: <4BE421D9.30502@siemens.com>
References: <4BE3FD3F.4070606@siemens.com> <20100507100758.1050a374@redhat.com>
	<4BE421D9.30502@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: Registering buffers with a qdict
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Fri, 07 May 2010 16:21:13 +0200
Jan Kiszka <jan.kiszka@siemens.com> wrote:

> Luiz Capitulino wrote:
> > On Fri, 07 May 2010 13:45:03 +0200
> > Jan Kiszka <jan.kiszka@siemens.com> wrote:
> > 
> >> Hi Luiz,
> >>
> >> what is the recommended way of pushing larger buffers (up to 64K so far)
> >> into a qdict? QLIST of QINT (one per byte) looks a bit heavy. I thought
> >> about hex-encoding the content first (series of "%02X"), then
> >> registering it as QSTRING. Or should we introduce a new type, QBUFFER?
> > 
> >  I don't think that hex-encoding the contents is so bad if your use case is
> > very specific and isolated.
> 
> The focus will be first on visualizing the buffer (user_print), but who
> knows what happens once the services is also exposed via QMP.
> 
> > 
> >  On the other hand, I do prefer a QBuffer type, specially because we can
> > have buffer operations.
> 
> The q<type>.c files look sufficiently simply, guess I will add a buffer
> type. Still, hex-encoding is probably the best representation for QMP.

 Yes, either as a string or (as suggested by Markus) an array of numbers,
if you wish to expose this via QMP you (or any of us) will have to update
the parser to support it.