* [Qemu-devel] [PATCH] virtio: invoke set_features on load
@ 2010-05-09 16:42 Michael S. Tsirkin
2010-05-10 14:41 ` [Qemu-devel] " David Stevens
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2010-05-09 16:42 UTC (permalink / raw)
To: qemu-devel, Anthony Liguori, dlstevens
After migration, vhost was not getting features
acked because set_features callback was never invoked.
The fix is just to invoke that callback.
Reported-by: David L Stevens <dlstevens@us.ibm.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
David, a tested-by tag would be appreciated.
hw/virtio.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hw/virtio.c b/hw/virtio.c
index 5d686f0..74c450d 100644
--- a/hw/virtio.c
+++ b/hw/virtio.c
@@ -692,6 +692,8 @@ int virtio_load(VirtIODevice *vdev, QEMUFile *f)
features, supported_features);
return -1;
}
+ if (vdev->set_features)
+ vdev->set_features(vdev, features);
vdev->guest_features = features;
vdev->config_len = qemu_get_be32(f);
qemu_get_buffer(f, vdev->config, vdev->config_len);
--
1.7.1.12.g42b7f
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Qemu-devel] Re: [PATCH] virtio: invoke set_features on load
2010-05-09 16:42 [Qemu-devel] [PATCH] virtio: invoke set_features on load Michael S. Tsirkin
@ 2010-05-10 14:41 ` David Stevens
0 siblings, 0 replies; 2+ messages in thread
From: David Stevens @ 2010-05-10 14:41 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-devel
"Michael S. Tsirkin" <mst@redhat.com> wrote on 05/09/2010 09:42:09 AM:
> After migration, vhost was not getting features
> acked because set_features callback was never invoked.
> The fix is just to invoke that callback.
>
> Reported-by: David L Stevens <dlstevens@us.ibm.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> David, a tested-by tag would be appreciated.
Tested-by: David L Stevens <dlstevens@us.ibm.com>
>
> hw/virtio.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/hw/virtio.c b/hw/virtio.c
> index 5d686f0..74c450d 100644
> --- a/hw/virtio.c
> +++ b/hw/virtio.c
> @@ -692,6 +692,8 @@ int virtio_load(VirtIODevice *vdev, QEMUFile *f)
> features, supported_features);
> return -1;
> }
> + if (vdev->set_features)
> + vdev->set_features(vdev, features);
> vdev->guest_features = features;
> vdev->config_len = qemu_get_be32(f);
> qemu_get_buffer(f, vdev->config, vdev->config_len);
> --
> 1.7.1.12.g42b7f
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-10 14:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-09 16:42 [Qemu-devel] [PATCH] virtio: invoke set_features on load Michael S. Tsirkin
2010-05-10 14:41 ` [Qemu-devel] " David Stevens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).