From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1OB9du-0006NT-Hq for qemu-devel@nongnu.org; Sun, 09 May 2010 12:46:14 -0400 Received: from [140.186.70.92] (port=40830 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OB9ds-0006N3-8o for qemu-devel@nongnu.org; Sun, 09 May 2010 12:46:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OB9dq-000837-PQ for qemu-devel@nongnu.org; Sun, 09 May 2010 12:46:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28176) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OB9dq-00082w-GU for qemu-devel@nongnu.org; Sun, 09 May 2010 12:46:10 -0400 Date: Sun, 9 May 2010 19:42:09 +0300 From: "Michael S. Tsirkin" Message-ID: <20100509164209.GA20658@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH] virtio: invoke set_features on load List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Anthony Liguori , dlstevens@us.ibm.com After migration, vhost was not getting features acked because set_features callback was never invoked. The fix is just to invoke that callback. Reported-by: David L Stevens Signed-off-by: Michael S. Tsirkin --- David, a tested-by tag would be appreciated. hw/virtio.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index 5d686f0..74c450d 100644 --- a/hw/virtio.c +++ b/hw/virtio.c @@ -692,6 +692,8 @@ int virtio_load(VirtIODevice *vdev, QEMUFile *f) features, supported_features); return -1; } + if (vdev->set_features) + vdev->set_features(vdev, features); vdev->guest_features = features; vdev->config_len = qemu_get_be32(f); qemu_get_buffer(f, vdev->config, vdev->config_len); -- 1.7.1.12.g42b7f