From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1OBQZH-0000hL-73 for qemu-devel@nongnu.org; Mon, 10 May 2010 06:50:35 -0400 Received: from [140.186.70.92] (port=57054 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OBQXr-0000Ba-Uh for qemu-devel@nongnu.org; Mon, 10 May 2010 06:50:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OBQVD-0008Mx-G2 for qemu-devel@nongnu.org; Mon, 10 May 2010 06:49:07 -0400 Received: from verein.lst.de ([213.95.11.210]:53689) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBQVA-0008L0-BA for qemu-devel@nongnu.org; Mon, 10 May 2010 06:46:23 -0400 Date: Mon, 10 May 2010 12:46:11 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH 2/3] cow: stop using mmap Message-ID: <20100510104611.GA3871@lst.de> References: <20100507151658.GA15132@lst.de> <20100507151719.GB15249@lst.de> <4BE7D4BB.5050205@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BE7D4BB.5050205@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Christoph Hellwig , qemu-devel@nongnu.org On Mon, May 10, 2010 at 11:41:15AM +0200, Kevin Wolf wrote: > For one, there is a typo in the variable name, and also this is a void > function which shouldn't return anything. The caller still seems to use > the return value. Should probably stay an int function. Yes, this was missing a quilt refresh after fixing that and running QA..