From: Paul Brook <paul@codesourcery.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Kevin Wolf <kwolf@redhat.com>,
armbru@redhat.com, qemu-devel@nongnu.org,
Alexander Graf <agraf@suse.de>, Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive
Date: Tue, 11 May 2010 16:53:52 +0100 [thread overview]
Message-ID: <201005111653.53208.paul@codesourcery.com> (raw)
In-Reply-To: <4BE97A58.2070907@codemonkey.ws>
> > I disagree. We should not be removing or rejecting features just because
> > they allow you to shoot yourself in the foot. We probably shouldn't be
> > enabling them by default, but that's a whole different question.
>
> I disagree and think the mentality severely hurts usability. QEMU's
> role should be to enable features, not to simplify every obscure
> feature. In general, if someone wants to accomplish something, we
> should try to provide a mechanism to accomplish it.
> cache=none|writeback|writethrough is an example of this. No one other
> than QEMU can control how we open a file descriptor so we need to
> provide a knob for it.
Doesn't the same argument apply to the existing cache=writethrough?
i.e. if you want to avoid data loss you should make sure your guest issues
flushes properly, and it's not something qemu should be trying to hack round
be adding an implicit flushe after every write.
Paul
next prev parent reply other threads:[~2010-05-11 15:54 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 21:51 [Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush Alexander Graf
2010-05-10 21:51 ` [Qemu-devel] [PATCH 1/2] Add no-op aio emulation stub Alexander Graf
2010-05-10 21:51 ` [Qemu-devel] [PATCH 2/2] Add flush=off parameter to -drive Alexander Graf
2010-05-11 8:36 ` [Qemu-devel] " Kevin Wolf
2010-05-11 10:55 ` Christoph Hellwig
2010-05-11 12:15 ` Paul Brook
2010-05-11 12:43 ` Anthony Liguori
2010-05-11 13:12 ` Paul Brook
2010-05-11 13:20 ` Anthony Liguori
2010-05-11 13:50 ` Paul Brook
2010-05-11 15:40 ` Anthony Liguori
2010-05-11 15:53 ` Paul Brook [this message]
2010-05-11 17:09 ` Anthony Liguori
2010-05-11 22:33 ` Paul Brook
2010-05-11 19:11 ` Avi Kivity
2010-05-11 16:32 ` Jamie Lokier
2010-05-11 17:15 ` Anthony Liguori
2010-05-11 18:13 ` Jamie Lokier
2010-05-11 15:18 ` Alexander Graf
2010-05-11 18:20 ` Jamie Lokier
2010-05-11 21:58 ` Paul Brook
2010-05-11 22:11 ` Paul Brook
2010-05-12 10:09 ` Jamie Lokier
2010-05-17 12:40 ` Christoph Hellwig
2010-05-14 9:16 ` Markus Armbruster
2010-05-17 12:41 ` Christoph Hellwig
2010-05-17 12:42 ` Alexander Graf
2010-05-11 19:04 ` Avi Kivity
2010-05-12 15:05 ` Alexander Graf
2010-05-12 15:36 ` Kevin Wolf
2010-05-12 15:51 ` Alexander Graf
2010-05-11 6:18 ` [Qemu-devel] [PATCH 1/2] Add no-op aio emulation stub Stefan Hajnoczi
2010-05-11 8:29 ` [Qemu-devel] " Kevin Wolf
2010-05-10 21:59 ` [Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush Anthony Liguori
2010-05-10 22:03 ` Alexander Graf
2010-05-10 22:12 ` Anthony Liguori
2010-05-11 21:48 ` Jamie Lokier
2010-05-12 8:51 ` Stefan Hajnoczi
2010-05-12 9:42 ` Jamie Lokier
2010-05-12 10:43 ` Stefan Hajnoczi
2010-05-12 12:50 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005111653.53208.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).