From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57339 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OCCW8-0001RX-Ce for qemu-devel@nongnu.org; Wed, 12 May 2010 10:02:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OCCW6-0003yb-BR for qemu-devel@nongnu.org; Wed, 12 May 2010 10:02:32 -0400 Received: from verein.lst.de ([213.95.11.210]:58264) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OCCW5-0003x8-VX for qemu-devel@nongnu.org; Wed, 12 May 2010 10:02:30 -0400 Date: Wed, 12 May 2010 16:01:32 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] [RFC PATCH 1/2] close all the block drivers before the qemu process exits Message-ID: <20100512140132.GA11876@lst.de> References: <1273661213-19611-1-git-send-email-morita.kazutaka@lab.ntt.co.jp> <1273661213-19611-2-git-send-email-morita.kazutaka@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1273661213-19611-2-git-send-email-morita.kazutaka@lab.ntt.co.jp> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: MORITA Kazutaka Cc: aliguori@us.ibm.com, sheepdog@lists.wpkg.org, kvm@vger.kernel.org, qemu-devel@nongnu.org, fujita.tomonori@lab.ntt.co.jp, avi@redhat.com On Wed, May 12, 2010 at 07:46:52PM +0900, MORITA Kazutaka wrote: > This patch calls the close handler of the block driver before the qemu > process exits. > > This is necessary because the sheepdog block driver releases the lock > of VM images in the close handler. > > Signed-off-by: MORITA Kazutaka Looks good in principle, except that bdrv_first is gone and has been replaced with a real list in the meantime, so this won't even apply.