From: Michael Walle <michael@walle.cc>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: Commit 9c9bb6c89d4 breaks code execution from flash
Date: Thu, 13 May 2010 01:02:23 +0200 [thread overview]
Message-ID: <201005130102.23124.michael@walle.cc> (raw)
In-Reply-To: <4BEA5F2F.8090107@web.de>
Am Wednesday 12 May 2010 09:56:31 schrieb Jan Kiszka:
> OK, that was a hard nut. After various dead ends, I think I found an
> possible solution. Can you give this a try?
[..]
> Still requires proper patch split up, and I need to think about possible
> side effects.
Thanks, the patch is working.
But i noticed another minor bug. The cfi02 doesn't handle 'read flash id' on
16bit accesses correctly. It always returns 8 bit. I used something like
if (width == 2)
ret = pfl->ident[0] << 8 | pfl->ident[1]; /* rsp. ident[1]/ident[2] */
within the 0x90 reading as a quick workaround.
--
michael
next prev parent reply other threads:[~2010-05-13 3:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 21:38 [Qemu-devel] Commit 9c9bb6c89d4 breaks code execution from flash Michael Walle
2010-04-23 7:23 ` [Qemu-devel] " Jan Kiszka
2010-05-07 20:57 ` Michael Walle
2010-05-12 7:56 ` Jan Kiszka
2010-05-12 23:02 ` Michael Walle [this message]
2010-05-13 7:38 ` Jan Kiszka
2010-05-13 10:58 ` Michael Walle
2010-05-13 11:46 ` Jan Kiszka
2010-05-13 11:57 ` Jan Kiszka
2010-05-13 12:38 ` Jan Kiszka
2010-05-13 13:51 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005130102.23124.michael@walle.cc \
--to=michael@walle.cc \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).