From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41146 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OCOzm-0008W1-OB for qemu-devel@nongnu.org; Wed, 12 May 2010 23:22:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OCKwe-0000O2-5o for qemu-devel@nongnu.org; Wed, 12 May 2010 19:02:29 -0400 Received: from mail.serverraum.org ([78.47.150.89]:52709) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OCKwe-0000NW-0z for qemu-devel@nongnu.org; Wed, 12 May 2010 19:02:28 -0400 From: Michael Walle Date: Thu, 13 May 2010 01:02:23 +0200 References: <201004222338.06194.michael@walle.cc> <201005072257.57198.michael@walle.cc> <4BEA5F2F.8090107@web.de> In-Reply-To: <4BEA5F2F.8090107@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <201005130102.23124.michael@walle.cc> Subject: [Qemu-devel] Re: Commit 9c9bb6c89d4 breaks code execution from flash List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org Am Wednesday 12 May 2010 09:56:31 schrieb Jan Kiszka: > OK, that was a hard nut. After various dead ends, I think I found an > possible solution. Can you give this a try? [..] > Still requires proper patch split up, and I need to think about possible > side effects. Thanks, the patch is working. But i noticed another minor bug. The cfi02 doesn't handle 'read flash id' on 16bit accesses correctly. It always returns 8 bit. I used something like if (width == 2) ret = pfl->ident[0] << 8 | pfl->ident[1]; /* rsp. ident[1]/ident[2] */ within the 0x90 reading as a quick workaround. -- michael