From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52455 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OCZux-0003eM-Ge for qemu-devel@nongnu.org; Thu, 13 May 2010 11:01:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OCZuv-0005El-2f for qemu-devel@nongnu.org; Thu, 13 May 2010 11:01:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33389) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OCZuu-0005Ed-Pa for qemu-devel@nongnu.org; Thu, 13 May 2010 11:01:41 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4DF1dsK004225 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 13 May 2010 11:01:39 -0400 Date: Thu, 13 May 2010 16:01:37 +0100 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc Message-ID: <20100513150136.GL12207@redhat.com> References: <1273086712-29163-1-git-send-email-lcapitulino@redhat.com> <1273086712-29163-2-git-send-email-lcapitulino@redhat.com> <4BEC031D.6020506@redhat.com> <20100513115524.29f826a0@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100513115524.29f826a0@redhat.com> Reply-To: "Daniel P. Berrange" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: bazulay@redhat.com, juzhang@redhat.com, Avi Kivity , armbru@redhat.com, qemu-devel@nongnu.org On Thu, May 13, 2010 at 11:55:24AM -0300, Luiz Capitulino wrote: > On Thu, 13 May 2010 16:48:13 +0300 > Avi Kivity wrote: > > > > > +change > > > +------ > > > + > > > +Change a removable medium or VNC configuration. > > > > > > > This is sad. Would anyone write a C function with a similar description? > > I wouldn't, but someone did for qemu. > > > Do we have this in 0.12? If not we can change (...) it. If we do, it's > > a more difficult deprecation process. > > Yes, we do and it's used by libvirt iirc. This command has been in QEMU for quite a long time now (0.9.x IIRC). IIRC, Gerd's SPICE proposal should include a brand new QMP command for setting both VNC and SPICE authentication information, since it has more than just a single password arg. At that point this use of change for VNC could be deprecated Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|