From: Jamie Lokier <jamie@shareable.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>, Brian Kress <kressb@moose.net>,
Avi Kivity <avi@redhat.com>, KVM list <kvm@vger.kernel.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus
Date: Thu, 13 May 2010 17:04:43 +0100 [thread overview]
Message-ID: <20100513160443.GA4417@shareable.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1005131329230.11380@kaball-desktop>
Stefano Stabellini wrote:
> > I think we need to consider only dstpitch for a full invalidate. We
> > might be copying an offscreen bitmap into the screen, and srcpitch is
> > likely to be the bitmap width instead of the screen pitch.
>
> Agreed.
Even when copying on-screen (or partially on-screen), the srcpitch
does not affect the invalidated area. The source area might be
strange (parallelogram, single line repeated), but srcpitch should
only affect whether qemu_console_copy can be used, not the
invalidation.
-- Jamie
next prev parent reply other threads:[~2010-05-13 16:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4BE32178.2090103@msgid.tls.msk.ru>
2010-05-10 7:41 ` [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus Avi Kivity
2010-05-10 8:15 ` Avi Kivity
2010-05-12 12:20 ` Stefano Stabellini
2010-05-12 12:36 ` Avi Kivity
2010-05-12 13:45 ` Stefano Stabellini
2010-05-12 14:27 ` Avi Kivity
2010-05-12 15:57 ` Stefano Stabellini
2010-05-12 16:07 ` Avi Kivity
2010-05-12 16:55 ` Stefano Stabellini
2010-05-12 16:57 ` Avi Kivity
2010-05-12 17:07 ` Jamie Lokier
2010-05-12 18:11 ` Stefano Stabellini
2010-05-12 19:12 ` Michael Tokarev
2010-05-13 6:49 ` Avi Kivity
2010-05-13 13:48 ` Stefano Stabellini
2010-05-13 14:13 ` Michael Tokarev
2010-05-13 18:03 ` Stefano Stabellini
2010-05-13 16:04 ` Jamie Lokier [this message]
2010-05-28 20:51 ` Michael Tokarev
2010-05-30 8:24 ` Avi Kivity
2010-05-13 7:36 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100513160443.GA4417@shareable.org \
--to=jamie@shareable.org \
--cc=avi@redhat.com \
--cc=kressb@moose.net \
--cc=kvm@vger.kernel.org \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).