From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36447 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OCau9-00025q-EA
	for qemu-devel@nongnu.org; Thu, 13 May 2010 12:05:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <jamie@shareable.org>) id 1OCau7-0006BR-SW
	for qemu-devel@nongnu.org; Thu, 13 May 2010 12:04:57 -0400
Received: from mail2.shareable.org ([80.68.89.115]:55198)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jamie@shareable.org>) id 1OCau7-0006BF-O8
	for qemu-devel@nongnu.org; Thu, 13 May 2010 12:04:55 -0400
Date: Thu, 13 May 2010 17:04:43 +0100
From: Jamie Lokier <jamie@shareable.org>
Subject: Re: [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus
Message-ID: <20100513160443.GA4417@shareable.org>
References: <4BEAA0CC.4090906@redhat.com>
	<alpine.DEB.2.00.1005121349070.11380@kaball-desktop>
	<4BEABABC.6080305@redhat.com>
	<alpine.DEB.2.00.1005121537370.11380@kaball-desktop>
	<4BEAD232.2040700@redhat.com>
	<alpine.DEB.2.00.1005121750480.11380@kaball-desktop>
	<20100512170702.GE19314@shareable.org>
	<alpine.DEB.2.00.1005121855230.11380@kaball-desktop>
	<4BEBA0ED.9010009@redhat.com>
	<alpine.DEB.2.00.1005131329230.11380@kaball-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.00.1005131329230.11380@kaball-desktop>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>, Brian Kress <kressb@moose.net>, Avi Kivity <avi@redhat.com>, KVM list <kvm@vger.kernel.org>, qemu-devel <qemu-devel@nongnu.org>

Stefano Stabellini wrote:
> > I think we need to consider only dstpitch for a full invalidate.  We 
> > might be copying an offscreen bitmap into the screen, and srcpitch is 
> > likely to be the bitmap width instead of the screen pitch.
> 
> Agreed.

Even when copying on-screen (or partially on-screen), the srcpitch
does not affect the invalidated area.  The source area might be
strange (parallelogram, single line repeated), but srcpitch should
only affect whether qemu_console_copy can be used, not the
invalidation.

-- Jamie