From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48862 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OCcIo-0007Th-5y
	for qemu-devel@nongnu.org; Thu, 13 May 2010 13:34:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <froydnj@codesourcery.com>) id 1OCcIk-0003t3-JV
	for qemu-devel@nongnu.org; Thu, 13 May 2010 13:34:29 -0400
Received: from mail.codesourcery.com ([38.113.113.100]:33050)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <froydnj@codesourcery.com>) id 1OCcIk-0003sa-FA
	for qemu-devel@nongnu.org; Thu, 13 May 2010 13:34:26 -0400
Date: Thu, 13 May 2010 10:27:43 -0700
From: Nathan Froyd <froydnj@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] ahci: convert enum to #define
Message-ID: <20100513172742.GC5834@codesourcery.com>
References: <1273771170$123@local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1273771170$123@local>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: qemu-devel@nongnu.org

On Thu, May 13, 2010 at 07:19:30PM +0200, Sebastian Herbszt wrote:
> Convert enum to #define.

This doesn't buy you anything except code churn.  It actually makes
things worse at usual debug levels, too, because the debugger
understands enums, but not #define.

-Nathan