From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=32789 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OCgPq-0005xL-Ve
	for qemu-devel@nongnu.org; Thu, 13 May 2010 17:58:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1OCgPo-000673-HC
	for qemu-devel@nongnu.org; Thu, 13 May 2010 17:58:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:65484)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1OCgPo-000663-9o
	for qemu-devel@nongnu.org; Thu, 13 May 2010 17:58:00 -0400
Received: from int-mx04.intmail.prod.int.phx2.redhat.com
	(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4DLvu6X028377
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 13 May 2010 17:57:56 -0400
Date: Thu, 13 May 2010 18:57:48 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc
Message-ID: <20100513185748.7bcaf32c@redhat.com>
In-Reply-To: <4BEC276F.1020103@redhat.com>
References: <1273086712-29163-1-git-send-email-lcapitulino@redhat.com>
	<1273086712-29163-2-git-send-email-lcapitulino@redhat.com>
	<4BEC031D.6020506@redhat.com> <20100513115524.29f826a0@redhat.com>
	<20100513150136.GL12207@redhat.com> <4BEC276F.1020103@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: bazulay@redhat.com, juzhang@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org

On Thu, 13 May 2010 19:23:11 +0300
Avi Kivity <avi@redhat.com> wrote:

> On 05/13/2010 06:01 PM, Daniel P. Berrange wrote:
> >
> >>   Yes, we do and it's used by libvirt iirc.
> >>      
> > This command has been in QEMU for quite a long time now (0.9.x IIRC).
> >    
> 
> It wasn't in QMP until 0.12.  We shouldn't have put it there in that form.

 Your main concern is stability? QMP in 0.12 and current are in preview
mode, ie. no stability contract until 0.13.

 We broke it already with a few changes (like capabilities support), so
anyone using QMP in 0.12 will have to update, although I don't think QMP
in 0.12 is that useful.

 Having said that, it's been stable for several weeks now and incompatible
changes have to be coordinated with libvirt.

 So, if you think this is worth the trouble someone could do it.

PS: I remember Anthony saying that he'd put somewhere that QMP is a
    preview version in 0.12. But I did not find anything, will submit
    a patch for stable.