[Qemu-devel] [PATCH 0/2] fix HelenOS illegal instruction issue on sparc64

[Qemu-devel] [PATCH 0/2] fix HelenOS illegal instruction issue on sparc64

[Igor V. Kovalenko]

The following series fix a couple of typos in sparc target which cause
illegal instruction issue booting HelenOS on sparc64.

---

Igor V. Kovalenko (2):
      sparc64: fix mmu demap operand typo
      sparc64: fix TT_WOTHER value


 target-sparc/cpu.h       |    2 +-
 target-sparc/op_helper.c |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
Kind regards,
Igor V. Kovalenko

[Qemu-devel] [PATCH 1/2] sparc64: fix mmu demap operand typo

[Igor V. Kovalenko]

From: Igor V. Kovalenko <igor.v.kovalenko@gmail.com>

- must use store address operand to demap, not store value

Signed-off-by: Igor V. Kovalenko <igor.v.kovalenko@gmail.com>
---
 target-sparc/op_helper.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/target-sparc/op_helper.c b/target-sparc/op_helper.c
index fcfd3f3..ec39244 100644
--- a/target-sparc/op_helper.c
+++ b/target-sparc/op_helper.c
@@ -2877,7 +2877,7 @@ void helper_st_asi(target_ulong addr, target_ulong val, int asi, int size)
             return;
         }
     case 0x57: // I-MMU demap
-        demap_tlb(env->itlb, val, "immu", env);
+        demap_tlb(env->itlb, addr, "immu", env);
         return;
     case 0x58: // D-MMU regs
         {
@@ -2942,7 +2942,7 @@ void helper_st_asi(target_ulong addr, target_ulong val, int asi, int size)
             return;
         }
     case 0x5f: // D-MMU demap
-        demap_tlb(env->dtlb, val, "dmmu", env);
+        demap_tlb(env->dtlb, addr, "dmmu", env);
         return;
     case 0x49: // Interrupt data receive
         // XXX

[Qemu-devel] [PATCH 2/2] sparc64: fix TT_WOTHER value

[Igor V. Kovalenko]

From: Igor V. Kovalenko <igor.v.kovalenko@gmail.com>

- fix off by one error in spill trap number bit for other window (must be bit 5)
- fixes invalid instruction issue with HelenOS
---
 target-sparc/cpu.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/target-sparc/cpu.h b/target-sparc/cpu.h
index 22f3ad0..27b020b 100644
--- a/target-sparc/cpu.h
+++ b/target-sparc/cpu.h
@@ -79,7 +79,7 @@
 #define TT_DPROT    0x6c
 #define TT_SPILL    0x80
 #define TT_FILL     0xc0
-#define TT_WOTHER   0x10
+#define TT_WOTHER   (1 << 5)
 #define TT_TRAP     0x100
 #endif
 

Re: [Qemu-devel] [PATCH 0/2] fix HelenOS illegal instruction issue on sparc64

[Blue Swirl]

Thanks, applied both.

On 5/16/10, Igor V. Kovalenko <igor.v.kovalenko@gmail.com> wrote:
> The following series fix a couple of typos in sparc target which cause
>  illegal instruction issue booting HelenOS on sparc64.
>
>  ---
>
>  Igor V. Kovalenko (2):
>       sparc64: fix mmu demap operand typo
>       sparc64: fix TT_WOTHER value
>
>
>   target-sparc/cpu.h       |    2 +-
>   target-sparc/op_helper.c |    4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)
>
>  --
>  Kind regards,
>
> Igor V. Kovalenko
>
>