From: Christoph Hellwig <hch@lst.de>
To: Avi Kivity <avi@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: fix aio_flush segfaults for read-only protocols (e.g. curl)
Date: Sun, 16 May 2010 15:21:59 +0200 [thread overview]
Message-ID: <20100516132159.GA26872@lst.de> (raw)
In-Reply-To: <1274011197-26196-1-git-send-email-avi@redhat.com>
On Sun, May 16, 2010 at 02:59:57PM +0300, Avi Kivity wrote:
> Not all block format drivers expose an io_flush method (reasonable for
> read-only protocols), so calling io_flush there will immediately segfault.
>
> Fix by checking for the method's existence before calling it.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2010-05-16 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-16 11:59 [Qemu-devel] [PATCH] block: fix aio_flush segfaults for read-only protocols (e.g. curl) Avi Kivity
2010-05-16 13:21 ` Christoph Hellwig [this message]
2010-05-17 9:10 ` [Qemu-devel] " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100516132159.GA26872@lst.de \
--to=hch@lst.de \
--cc=avi@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).