From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Alexander Graf <agraf@suse.de>, hch@lst.de
Subject: Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive
Date: Mon, 17 May 2010 17:23:15 +0100 [thread overview]
Message-ID: <201005171723.15675.paul@codesourcery.com> (raw)
In-Reply-To: <4BF15DC8.8080104@codemonkey.ws>
> > I don't see a difference between the results. Apparently the barrier
> > option doesn't change a thing.
>
> Ok. I don't like it, but I can see how it's compelling. I'd like to
> see the documentation improved though. I also think a warning printed
> on stdio about the safety of the option would be appropriate.
I disagree with this last bit.
Errors should be issued if the user did something wrong.
Warnings should be issued if qemu did (or will soon do) something other than
what the user requested, or otherwise made questionable decisions on the
user's behalf.
In this case we're doing exactly what the user requested. The only plausible
failure case is where a user is blindly trying options that they clearly don't
understand or read the documentation for. I have zero sympathy for complaints
like "Someone on the Internet told me to use --breakme, and broke thinks".
Paul
next prev parent reply other threads:[~2010-05-17 16:23 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 10:14 [Qemu-devel] [PATCH] Add cache=volatile parameter to -drive Alexander Graf
2010-05-17 10:42 ` [Qemu-devel] " Kevin Wolf
2010-05-17 12:58 ` Anthony Liguori
2010-05-17 13:02 ` Alexander Graf
2010-05-17 13:09 ` Anthony Liguori
2010-05-17 13:17 ` Alexander Graf
2010-05-17 13:26 ` Anthony Liguori
2010-05-17 14:04 ` Alexander Graf
2010-05-17 14:22 ` Alexander Graf
2010-05-17 15:16 ` Anthony Liguori
2010-05-17 16:23 ` Paul Brook [this message]
2010-05-17 16:26 ` Anthony Liguori
2010-05-17 16:28 ` Alexander Graf
2010-05-17 20:07 ` Jamie Lokier
2010-05-18 7:42 ` Kevin Wolf
2010-05-25 17:59 ` Alexander Graf
2010-05-25 18:48 ` Anthony Liguori
2010-05-25 19:01 ` Alexander Graf
2010-05-26 13:09 ` Avi Kivity
2010-05-25 21:01 ` Aurelien Jarno
2010-05-26 1:31 ` Anthony Liguori
2010-05-26 8:43 ` Kevin Wolf
2010-05-26 13:42 ` Anthony Liguori
2010-05-26 14:03 ` Kevin Wolf
2010-05-26 14:08 ` Anthony Liguori
2010-05-26 14:26 ` Kevin Wolf
2010-05-26 14:13 ` Aurelien Jarno
2010-05-26 8:52 ` Aurelien Jarno
2010-05-26 9:16 ` Kevin Wolf
2010-05-26 13:48 ` Anthony Liguori
2010-05-26 14:12 ` Aurelien Jarno
2010-05-26 14:19 ` Anthony Liguori
2010-05-26 15:40 ` Aurelien Jarno
2010-05-26 16:11 ` Anthony Liguori
2010-05-26 14:27 ` Paolo Bonzini
2010-05-26 13:06 ` Avi Kivity
2010-05-26 13:50 ` Anthony Liguori
2010-05-26 15:13 ` Avi Kivity
2010-05-17 15:11 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005171723.15675.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=agraf@suse.de \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).