From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=48115 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OEMBG-0001NZ-Ud for qemu-devel@nongnu.org; Tue, 18 May 2010 08:45:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OEMBD-0006jR-Fi for qemu-devel@nongnu.org; Tue, 18 May 2010 08:45:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38448) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OEMBD-0006j9-8T for qemu-devel@nongnu.org; Tue, 18 May 2010 08:45:51 -0400 Date: Tue, 18 May 2010 09:45:42 -0300 From: Luiz Capitulino Subject: Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc Message-ID: <20100518094542.64d5bae0@redhat.com> In-Reply-To: References: <1273086712-29163-1-git-send-email-lcapitulino@redhat.com> <1273086712-29163-2-git-send-email-lcapitulino@redhat.com> <4BEC031D.6020506@redhat.com> <4BED6F85.50309@redhat.com> <20100514195428.64709257@redhat.com> <4BEE3CED.3070801@redhat.com> <4BF18680.2030501@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: bazulay@redhat.com, juzhang@redhat.com, Avi Kivity , qemu-devel@nongnu.org On Tue, 18 May 2010 11:51:26 +0200 Markus Armbruster wrote: > Anthony Liguori writes: > > > On 05/15/2010 01:19 AM, Avi Kivity wrote: > >> On 05/15/2010 01:54 AM, Luiz Capitulino wrote: > >>> On Fri, 14 May 2010 19:03:36 +0200 > >>> Markus Armbruster wrote: > >>> > >>>>> What about PCI domains? > >>>> Good point. Better to provide for them neatly now, instead of kludging > >>>> them in later. > >>> When I did this conversion I asked Micheal for help with that and > >>> he said > >>> QEMU doesn't support PCI domains. > >> > >> That's very different from "will never support pci domains". > >> > >> The protocol must be forward looking, or we will need endless fixes > >> for it. > > > > But we can always add a domain property to extend the address (with a > > default domain of 0). > > Why not add it right away? The plan is to merge the doc and work on all changes suggested by Avi (always coordinating with libvirt, of course). Although query-pci is not used there. > Note that if we'd decide to adopt Avi's suggestion to make this "a > nested object (list of buses, each containing a list of slots, each > containing a list of functions)", then we can't easily add domains > later, because that would insert a level of nesting near the top. Right.