From: Aurelien Jarno <aurelien@aurel32.net>
To: Serge Ziryukin <ftrvxmtrx@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] audio/alsa: fix comparison between requested and obtained formats
Date: Tue, 18 May 2010 20:40:32 +0200 [thread overview]
Message-ID: <20100518184032.GG31346@ohm.aurel32.net> (raw)
In-Reply-To: <20100421082010.GA22649@ftrvxmtrx>
On Wed, Apr 21, 2010 at 11:20:10AM +0300, Serge Ziryukin wrote:
> Trivial patch which uses aud_to_alsafmt to fix comparison
> between alsa and internal audio pcm format enum.
> ---
> audio/alsaaudio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Acked-by: Aurelien Jarno <aurelien@aurel32.net>
> diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c
> index 88344ff..d784476 100644
> --- a/audio/alsaaudio.c
> +++ b/audio/alsaaudio.c
> @@ -666,7 +666,7 @@ static int alsa_open (int in, struct alsa_params_req *req,
> *handlep = handle;
>
> if (conf.verbose &&
> - (obt->fmt != req->fmt ||
> + (aud_to_alsafmt(obt->fmt) != req->fmt ||
> obt->nchannels != req->nchannels ||
> obt->freq != req->freq)) {
> dolog ("Audio parameters for %s\n", typ);
> --
> 1.7.0.5
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2010-05-18 18:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 8:20 [Qemu-devel] [PATCH] audio/alsa: fix comparison between requested and obtained formats Serge Ziryukin
2010-05-18 18:40 ` Aurelien Jarno [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-04-21 11:01 Serge Ziryukin
2010-04-21 11:41 ` malc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100518184032.GG31346@ohm.aurel32.net \
--to=aurelien@aurel32.net \
--cc=ftrvxmtrx@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).