* [Qemu-devel] [PATCH] audio/alsa: fix comparison between requested and obtained formats
@ 2010-04-21 8:20 Serge Ziryukin
2010-05-18 18:40 ` Aurelien Jarno
0 siblings, 1 reply; 4+ messages in thread
From: Serge Ziryukin @ 2010-04-21 8:20 UTC (permalink / raw)
To: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 703 bytes --]
Trivial patch which uses aud_to_alsafmt to fix comparison
between alsa and internal audio pcm format enum.
---
audio/alsaaudio.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c
index 88344ff..d784476 100644
--- a/audio/alsaaudio.c
+++ b/audio/alsaaudio.c
@@ -666,7 +666,7 @@ static int alsa_open (int in, struct alsa_params_req *req,
*handlep = handle;
if (conf.verbose &&
- (obt->fmt != req->fmt ||
+ (aud_to_alsafmt(obt->fmt) != req->fmt ||
obt->nchannels != req->nchannels ||
obt->freq != req->freq)) {
dolog ("Audio parameters for %s\n", typ);
--
1.7.0.5
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Qemu-devel] [PATCH] audio/alsa: fix comparison between requested and obtained formats
@ 2010-04-21 11:01 Serge Ziryukin
2010-04-21 11:41 ` malc
0 siblings, 1 reply; 4+ messages in thread
From: Serge Ziryukin @ 2010-04-21 11:01 UTC (permalink / raw)
To: qemu-devel
Trivial patch which uses aud_to_alsafmt to fix comparison
between alsa and internal audio pcm format enum.
---
audio/alsaaudio.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c
index 88344ff..d784476 100644
--- a/audio/alsaaudio.c
+++ b/audio/alsaaudio.c
@@ -666,7 +666,7 @@ static int alsa_open (int in, struct alsa_params_req *req,
*handlep = handle;
if (conf.verbose &&
- (obt->fmt != req->fmt ||
+ (aud_to_alsafmt(obt->fmt) != req->fmt ||
obt->nchannels != req->nchannels ||
obt->freq != req->freq)) {
dolog ("Audio parameters for %s\n", typ);
--
1.7.0.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] audio/alsa: fix comparison between requested and obtained formats
2010-04-21 11:01 Serge Ziryukin
@ 2010-04-21 11:41 ` malc
0 siblings, 0 replies; 4+ messages in thread
From: malc @ 2010-04-21 11:41 UTC (permalink / raw)
To: Serge Ziryukin; +Cc: qemu-devel
On Wed, 21 Apr 2010, Serge Ziryukin wrote:
> Trivial patch which uses aud_to_alsafmt to fix comparison
> between alsa and internal audio pcm format enum.
I've commited slightly different patch, thanks for spotting this.
--
mailto:av1474@comtv.ru
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] audio/alsa: fix comparison between requested and obtained formats
2010-04-21 8:20 [Qemu-devel] [PATCH] audio/alsa: fix comparison between requested and obtained formats Serge Ziryukin
@ 2010-05-18 18:40 ` Aurelien Jarno
0 siblings, 0 replies; 4+ messages in thread
From: Aurelien Jarno @ 2010-05-18 18:40 UTC (permalink / raw)
To: Serge Ziryukin; +Cc: qemu-devel
On Wed, Apr 21, 2010 at 11:20:10AM +0300, Serge Ziryukin wrote:
> Trivial patch which uses aud_to_alsafmt to fix comparison
> between alsa and internal audio pcm format enum.
> ---
> audio/alsaaudio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Acked-by: Aurelien Jarno <aurelien@aurel32.net>
> diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c
> index 88344ff..d784476 100644
> --- a/audio/alsaaudio.c
> +++ b/audio/alsaaudio.c
> @@ -666,7 +666,7 @@ static int alsa_open (int in, struct alsa_params_req *req,
> *handlep = handle;
>
> if (conf.verbose &&
> - (obt->fmt != req->fmt ||
> + (aud_to_alsafmt(obt->fmt) != req->fmt ||
> obt->nchannels != req->nchannels ||
> obt->freq != req->freq)) {
> dolog ("Audio parameters for %s\n", typ);
> --
> 1.7.0.5
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-05-18 18:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-21 8:20 [Qemu-devel] [PATCH] audio/alsa: fix comparison between requested and obtained formats Serge Ziryukin
2010-05-18 18:40 ` Aurelien Jarno
-- strict thread matches above, loose matches on Subject: below --
2010-04-21 11:01 Serge Ziryukin
2010-04-21 11:41 ` malc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).