From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41628 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OERkN-0003ZK-Nq for qemu-devel@nongnu.org; Tue, 18 May 2010 14:42:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OERiW-0004pY-2u for qemu-devel@nongnu.org; Tue, 18 May 2010 14:40:38 -0400 Received: from hall.aurel32.net ([88.191.82.174]:46359) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OERiV-0004pG-G7 for qemu-devel@nongnu.org; Tue, 18 May 2010 14:40:36 -0400 Date: Tue, 18 May 2010 20:40:32 +0200 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] audio/alsa: fix comparison between requested and obtained formats Message-ID: <20100518184032.GG31346@ohm.aurel32.net> References: <20100421082010.GA22649@ftrvxmtrx> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20100421082010.GA22649@ftrvxmtrx> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Ziryukin Cc: qemu-devel@nongnu.org On Wed, Apr 21, 2010 at 11:20:10AM +0300, Serge Ziryukin wrote: > Trivial patch which uses aud_to_alsafmt to fix comparison > between alsa and internal audio pcm format enum. > --- > audio/alsaaudio.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Acked-by: Aurelien Jarno > diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c > index 88344ff..d784476 100644 > --- a/audio/alsaaudio.c > +++ b/audio/alsaaudio.c > @@ -666,7 +666,7 @@ static int alsa_open (int in, struct alsa_params_req *req, > *handlep = handle; > > if (conf.verbose && > - (obt->fmt != req->fmt || > + (aud_to_alsafmt(obt->fmt) != req->fmt || > obt->nchannels != req->nchannels || > obt->freq != req->freq)) { > dolog ("Audio parameters for %s\n", typ); > -- > 1.7.0.5 > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net