From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52036 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OEjkG-0007vJ-UQ
	for qemu-devel@nongnu.org; Wed, 19 May 2010 09:55:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1OEjkF-0000XO-Jv
	for qemu-devel@nongnu.org; Wed, 19 May 2010 09:55:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53034)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1OEjkF-0000XH-8o
	for qemu-devel@nongnu.org; Wed, 19 May 2010 09:55:35 -0400
Date: Wed, 19 May 2010 10:55:27 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20100519105527.16f98bb8@redhat.com>
In-Reply-To: <4BF3ECC0.3090808@siemens.com>
References: <1274232769-11160-1-git-send-email-lcapitulino@redhat.com>
	<1274232769-11160-3-git-send-email-lcapitulino@redhat.com>
	<4BF3AC24.8050401@siemens.com> <20100519100629.3009bee7@redhat.com>
	<4BF3E803.30405@siemens.com> <20100519104616.474bb72b@redhat.com>
	<4BF3ECC0.3090808@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/3] QMP: Introduce commands documentation
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: "armbru@redhat.com" <armbru@redhat.com>, "aliguori@us.ibm.com" <aliguori@us.ibm.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "avi@redhat.com" <avi@redhat.com>

On Wed, 19 May 2010 15:50:56 +0200
Jan Kiszka <jan.kiszka@siemens.com> wrote:

> Luiz Capitulino wrote:
> > On Wed, 19 May 2010 15:30:43 +0200
> > Jan Kiszka <jan.kiszka@siemens.com> wrote:
> > 
> >> Luiz Capitulino wrote:
> > 
> > [...]
> > 
> >>>  I didn't submit the syntax checking bits on purpose, there's something
> >>> failing there and I didn't want to check it now.
> >> You already did for QMP, just skipped the STEXI/ETEXI balancing checks.
> >> And if that reports an error for TEXI, better have a closer look. It
> >> worked fine with my tree, so something may have regressed.
> > 
> >  Here you go:
> > 
> > """
> > GEN   qemu-img-cmds.texi
> > line 10: syntax error: expected ETEXI, found STEXI
> > make: *** [qemu-img-cmds.texi] Error 1
> > make: *** Deleting file `qemu-img-cmds.texi'
> > """
> > 
> >  Indeed, looks like a bug in qemu-img-cmds.hx:
> > 
> > """
> > STEXI
> > @table @option
> > STEXI
> > """
> 
> Oh, then I also did no "make clean all" run with my patch applied that
> night... :] Still, good to know that it works. I can handle this if you
> don't want to.

 Please do, you could send both patches in the same series (ie. fix and
feature), so that we don't break the build.