From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50627 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OF2Ya-0007WQ-QG for qemu-devel@nongnu.org; Thu, 20 May 2010 06:00:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OF2YX-0008BQ-Lx for qemu-devel@nongnu.org; Thu, 20 May 2010 06:00:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25587) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OF2YX-0008BF-BN for qemu-devel@nongnu.org; Thu, 20 May 2010 06:00:45 -0400 Date: Thu, 20 May 2010 11:00:39 +0100 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH] Name the default PCI bus "pci.0" on all architectures Message-ID: <20100520100039.GB28087@redhat.com> References: <1274287377-19424-1-git-send-email-berrange@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Reply-To: "Daniel P. Berrange" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org On Wed, May 19, 2010 at 10:19:06PM +0300, Blue Swirl wrote: > On 5/19/10, Daniel P. Berrange wrote: > > The system emulators for each arch are using inconsistent > > naming for the default PCI bus "pci" vs "pci.0". Since it > > is conceivable we'll have multiple PCI buses in the future > > standardize on "pci.0" for all architectures. This ensures > > mgmt apps can rely on a name when assigning PCI devices an > > address on the bus using eg '-device e1000,bus=pci.0,addr=3' > > > > Signed-off-by: Daniel P. Berrange > > --- > > hw/grackle_pci.c | 2 +- > > hw/gt64xxx.c | 2 +- > > hw/ppc4xx_pci.c | 2 +- > > hw/ppce500_pci.c | 2 +- > > hw/prep_pci.c | 2 +- > > hw/sh_pci.c | 2 +- > > hw/unin_pci.c | 4 ++-- > > hw/versatile_pci.c | 2 +- > > Missing hw/apb_pci.c. Ah yes, don't know how I missed that. Have posted another version of this patch with that included Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|