From: Rabin Vincent <rabin@rab.in>
To: qemu-devel@nongnu.org
Cc: paul@codesourcery.com
Subject: [Qemu-devel] Re: [PATCH 1/2] arm_timer: reload timer when enabled
Date: Thu, 20 May 2010 22:57:42 +0530 [thread overview]
Message-ID: <20100520172741.GA28134@debian> (raw)
In-Reply-To: <1272793852-26260-1-git-send-email-rabin@rab.in>
On Sun, May 02, 2010 at 03:20:51PM +0530, Rabin Vincent wrote:
> Reload the timer when TimerControl is written, if the timer is to be
> enabled. Otherwise, if an earlier write to TimerLoad was done while
> periodic mode was not set, s->delta may incorrectly still have the value
> of the maximum limit instead of the value written to TimerLoad.
>
> This problem is evident on versatileap on current linux-next, which
> enables TIMER_CTRL_32BIT before writing to TimerLoad and then enabling
> periodic mode and starting the timer. This causes the first periodic
> tick to be scheduled to occur after 0xffffffff periods, leading to a
> perceived hang while the kernel waits for the first timer tick.
>
> Signed-off-by: Rabin Vincent <rabin@rab.in>
Could these patches please be applied? What was then linux-next is now
current Linux mainline, and it doesn't boot without this patch.
Rabin
next prev parent reply other threads:[~2010-05-20 17:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-02 9:50 [Qemu-devel] [PATCH 1/2] arm_timer: reload timer when enabled Rabin Vincent
2010-05-02 9:50 ` [Qemu-devel] [PATCH 2/2] arm_timer: fix oneshot mode Rabin Vincent
2010-05-21 10:00 ` Aurelien Jarno
2010-05-20 17:27 ` Rabin Vincent [this message]
2010-05-21 10:00 ` [Qemu-devel] [PATCH 1/2] arm_timer: reload timer when enabled Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100520172741.GA28134@debian \
--to=rabin@rab.in \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).